From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3QYs-0006RW-Tt
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:59:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3QYm-00069B-Se
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:58:58 -0400
Received: from cantor2.suse.de ([195.135.220.15]:60346 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3QYm-00067r-MY
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:58:52 -0400
Message-ID: <51F51586.2020305@suse.de>
Date: Sun, 28 Jul 2013 14:58:46 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375014954-31916-1-git-send-email-pbonzini@redhat.com>
	<51F51262.1090808@suse.de> <51F514C1.3030003@redhat.com>
In-Reply-To: <51F514C1.3030003@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO
	reads/writes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 28.07.2013 14:55, schrieb Paolo Bonzini:
> Il 28/07/2013 14:45, Andreas F=E4rber ha scritto:
>> Am 28.07.2013 14:35, schrieb Paolo Bonzini:
>>> diff --git a/trace-events b/trace-events
>>> index 002df83..3e0dd74 100644
>>> --- a/trace-events
>>> +++ b/trace-events
>>> @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, ar=
g %p"
>>>  kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, ty=
pe %d, arg %p"
>>>  kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %=
d"
>>> =20
>>> +# memory.c
>>> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsi=
gned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>>> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, uns=
igned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>>
>> %u would seem more correct for unsigned - if you fix that, Reviewed-by=
:
>> Andreas F=E4rber <afaerber@suse.de> and ACK that's it's good for 1.6.
>=20
> Ok, though it can only be 1/2/4/8.

I had static analysis in mind. ;)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg