From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3RGs-00060B-4B
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 09:44:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3RGk-00042Q-QH
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 09:44:26 -0400
Received: from cantor2.suse.de ([195.135.220.15]:32866 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3RGk-00042G-KK
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 09:44:18 -0400
Message-ID: <51F5202C.6060602@suse.de>
Date: Sun, 28 Jul 2013 15:44:12 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374975670-8820-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1374975670-8820-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState
 cleanups for 1.6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

Am 28.07.2013 03:41, schrieb Andreas F=C3=A4rber:
> Patch 1 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>    - Field X
>      ...
> b) - Struct A
>      - Field Aa
>      ...
>      - Field X
>=20
> Patch 2 relies on XHCI not being released yet, thus no compatibiliy con=
cerns.
>=20
> Patch 3 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>      - Field X
> b) - Struct A
>      - Field Aa
>      ...
>      - Subsection Ax
>        - Field X
>=20
> CC'ing Juan to verify which of these are correct/safe.

If the answer is "doing both as subsections will work fine" then this
series could be postponed post-1.6, of course.

Looking deeper at PCI devices, I notice that while XHCI was the only
device to use VMSTATE_MSIX() macro, other devices were using
msix_init*() as well, namely
* nvme (unmigratable)
* pci-assign (unmigratable)
* vfio (unmigratable)
* vmxnet3 - does an extra register_savevm() just for msix_save()
* ivshmem - calling msix_save() conditionally after pci_device_save()
* virtio-pci - calling msix_save() conditionally after pci_device_save()
* megasas - #ifdef USE_MSIX'ed out, will need changes

CC'ing net and scsi maintainers and Hannes.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg