From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3SRX-0004fk-R0 for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:59:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3SRQ-0001oV-HT for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:59:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34158 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3SRQ-0001n2-7H for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:59:24 -0400 Message-ID: <51F531C6.8010302@suse.de> Date: Sun, 28 Jul 2013 16:59:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374975670-8820-1-git-send-email-afaerber@suse.de> <20130728140853.GA22158@redhat.com> In-Reply-To: <20130728140853.GA22158@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Gerd Hoffmann , qemu-devel@nongnu.org, Anthony Liguori , Juan Quintela Am 28.07.2013 16:08, schrieb Michael S. Tsirkin: > On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas F=E4rber wrote: >> Hello Michael and Gerd, >> >> As discussed, this series attempts to clean up PCIe devices fiddling w= ith >> individual PCIe VMState fields. It is based on my qom-next queue, cont= aining >> type and field changes for PCIe devices. >> >> Patch 1 assumes the following are equivalent: >> a) - Struct A >> - Field Aa >> ... >> - Field X >> ... >> b) - Struct A >> - Field Aa >> ... >> - Field X >> >> Patch 2 relies on XHCI not being released yet, thus no compatibiliy co= ncerns. >> >> Patch 3 assumes the following are equivalent: >> a) - Struct A >> - Field Aa >> ... >> - Field X >> b) - Struct A >> - Field Aa >> ... >> - Subsection Ax >> - Field X >> >> CC'ing Juan to verify which of these are correct/safe. >=20 > As far as I know 2a and 2b are not equivalent: subsections > are serialized in the file. I'm guessing you mean scenarios 3a and 3b. Too bad. But when we want to unify PCI and PCIe as you suggested elsewhere, introducing a PCIe-only subsection in patch 2 seems a bad idea. In that case we could use VMSTATE_STRUCT_TEST(), I'll look into that. Using that I think we can postpone this beyond 1.6, since XHCI is not initializing AER. Series formally retracted. > You really should test by migrating to file (e.g. before > starting the guest) and checking. > Also, migrate to file from before patch and load after patch. OK. For virtio and NICs that's trivial and for the ioh there's docs/q35-chipset.cfg. How do I use and test those xio upstream/downstream PCIe devices? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg