qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes
Date: Sun, 28 Jul 2013 17:02:01 +0200	[thread overview]
Message-ID: <51F53269.5000503@suse.de> (raw)
In-Reply-To: <CAFEAcA82A1k+x3cL_Wanhen-A+Hd_DXQtybZ0gZCOGphg0Z7Qw@mail.gmail.com>

Am 28.07.2013 16:34, schrieb Peter Maydell:
> On 28 July 2013 13:35, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> This is quite handy to debug softmmu targets.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> (not a nak, just a tangential thought)
> It would be cute if you could just insert a "trace this access
> and pass it through" container MemoryRegion at an arbitrary
> point in the memory region hierarchy. That would let us do
> "trace accesses to device X" without device X having to
> have boilerplate tracing code in its read/write functions.

The SystemTap backend for instance allows you to filter what you print
based on arguments, i.e. address and size.

Are you suggesting to make the trace points in this patch conditional on
some new mr->tracing_enabled flag in the MemoryRegion?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-07-28 15:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-28 12:35 [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes Paolo Bonzini
2013-07-28 12:45 ` Andreas Färber
2013-07-28 12:55   ` Paolo Bonzini
2013-07-28 12:58     ` Andreas Färber
2013-07-28 14:34 ` Peter Maydell
2013-07-28 15:02   ` Andreas Färber [this message]
2013-08-05 15:18 ` Don Slutz
2013-08-05 16:20   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F53269.5000503@suse.de \
    --to=afaerber@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).