From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3Xg4-0007pO-NQ
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 16:34:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3Xfz-0002To-HC
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 16:34:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40523 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3Xfz-0002Td-AI
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 16:34:47 -0400
Message-ID: <51F58061.5020509@suse.de>
Date: Sun, 28 Jul 2013 22:34:41 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1373245434-25502-1-git-send-email-afaerber@suse.de>
	<20130708144054.36655c55@nial.usersys.redhat.com>
In-Reply-To: <20130708144054.36655c55@nial.usersys.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v9] target-i386: Move hyperv_*
 static globals to X86CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, kvm <kvm@vger.kernel.org>

Am 08.07.2013 14:40, schrieb Igor Mammedov:
> On Mon,  8 Jul 2013 03:03:54 +0200
> Andreas F=E4rber <afaerber@suse.de> wrote:
>=20
>> From: Igor Mammedov <imammedo@redhat.com>
>>
>> - since hyperv_* helper functions are used only in target-i386/kvm.c
>>   move them there as static helpers
>>
>> Requested-by: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
> I'm not tested it yet, but it looks good to me.

Being from you originally and me having confidence in my changes on top,
I'm queuing this on qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next

Andreas

>> ---
>>  v8 (imammedo) -> v9:
>>  * Use X86CPU instead of CPUX86State (only used in KVM)
>>  * Changed helper functions to X86CPU argument
>>  * Moved field initialization to QOM instance_init
>>  * Fixed subject (not today's "CPUState")
>>
>>  target-i386/Makefile.objs |  2 +-
>>  target-i386/cpu-qom.h     |  4 +++
>>  target-i386/cpu.c         | 16 ++++++++----
>>  target-i386/cpu.h         |  4 +++
>>  target-i386/hyperv.c      | 64 --------------------------------------=
---------
>>  target-i386/hyperv.h      | 45 ---------------------------------
>>  target-i386/kvm.c         | 36 ++++++++++++++++++--------
>>  7 files changed, 46 insertions(+), 125 deletions(-)
>>  delete mode 100644 target-i386/hyperv.c
>>  delete mode 100644 target-i386/hyperv.h

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg