From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd
Date: Mon, 29 Jul 2013 10:05:46 +0800 [thread overview]
Message-ID: <51F5CDFA.6030400@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130726082057.GB31438@stefanha-thinkpad.redhat.com>
于 2013-7-26 16:20, Stefan Hajnoczi 写道:
> On Fri, Jul 26, 2013 at 10:23:24AM +0800, Wenchao Xia wrote:
>> 于 2013-7-25 16:06, Stefan Hajnoczi 写道:
>>> On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote:
>>>> Besides the argument, I think it helps to probe snapshot without
>>>> qemu-img convert, hope to get comments for the code.
>>>
>>> Hi Wenchao,
>>> Which patch are you referring to?
>>>
>>> Stefan
>>>
>> This series, which enable qemu-nbd load a snapshot. It is quite
>> simple, look forward to your opinion, especially the parameter of
>> qemu-nbd part in patch 2.
>
> I understand now. Adding bdrv_snapshot_load_tmp() support to qemu-nbd
> is useful, it's a shame that the --snapshot/-s option is already taken
> and likely to cause confusion. The documentation needs to be very clear
> that --snapshot and --snapshot-load refer to different snapshot
> concepts.
>
I'll add that section about the difference.
> Stefan
>
--
Best Regards
Wenchao Xia
prev parent reply other threads:[~2013-07-29 2:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:03 [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 1/4] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 2/4] qemu-nbd: support internal snapshot export Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for " Wenchao Xia
2013-07-26 8:11 ` Stefan Hajnoczi
2013-07-29 1:57 ` Wenchao Xia
2013-07-29 7:39 ` Stefan Hajnoczi
2013-07-17 14:03 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: add 057 internal snapshot export with qemu-nbd case Wenchao Xia
2013-07-17 14:23 ` [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd Eric Blake
2013-07-17 15:21 ` Kevin Wolf
2013-07-18 2:28 ` Wenchao Xia
2013-07-18 7:15 ` Fam Zheng
2013-07-19 6:29 ` Wenchao Xia
2013-07-19 8:20 ` Kevin Wolf
2013-07-22 5:20 ` Wenchao Xia
2013-07-18 5:43 ` Stefan Hajnoczi
2013-07-19 9:03 ` Wenchao Xia
2013-07-19 9:19 ` Kevin Wolf
2013-07-19 10:02 ` Wenchao Xia
2013-07-22 2:10 ` Fam Zheng
2013-07-22 3:26 ` Wenchao Xia
2013-07-25 2:30 ` Wenchao Xia
2013-07-25 8:06 ` Stefan Hajnoczi
2013-07-26 2:23 ` Wenchao Xia
2013-07-26 8:20 ` Stefan Hajnoczi
2013-07-29 2:05 ` Wenchao Xia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F5CDFA.6030400@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).