From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hbu-0005qP-Q3 for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:11:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3hbl-00061R-RJ for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:11:14 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:33601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hbl-000618-6z for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:11:05 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2013 17:07:56 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 82D1D2BB0054 for ; Mon, 29 Jul 2013 17:10:56 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6T6tH9o66584776 for ; Mon, 29 Jul 2013 16:55:17 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6T7AtSd020130 for ; Mon, 29 Jul 2013 17:10:56 +1000 Message-ID: <51F61576.9000309@linux.vnet.ibm.com> Date: Mon, 29 Jul 2013 15:10:46 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374765505-14356-1-git-send-email-stefanha@redhat.com> <1374765505-14356-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1374765505-14356-4-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 03/18] dataplane/virtio-blk: check exit conditions before aio_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Ping Fan Liu , qemu-devel@nongnu.org, Michael Roth , alex@alex.org.uk, Paolo Bonzini > Check exit conditions before entering blocking aio_poll(). This is > mainly for consistency since it's unlikely that we are stopping in the > first event loop iteration. > > Signed-off-by: Stefan Hajnoczi > --- > hw/block/dataplane/virtio-blk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c > index 2faed43..8d3e145 100644 > --- a/hw/block/dataplane/virtio-blk.c > +++ b/hw/block/dataplane/virtio-blk.c > @@ -379,9 +379,9 @@ static void *data_plane_thread(void *opaque) > { > VirtIOBlockDataPlane *s = opaque; > > - do { > + while (!s->stopping || s->num_reqs > 0) { > aio_poll(s->ctx, true); > - } while (!s->stopping || s->num_reqs > 0); > + } > return NULL; > } > It seems more likely a bug fix. Reviewed-by: Wenchao Xia -- Best Regards Wenchao Xia