From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3ieP-0004X4-B3 for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:18:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3ieG-0002Pk-EV for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:17:53 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:57299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3ieF-0002PU-Qu for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:17:44 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2013 18:07:54 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id D006C2CE804C for ; Mon, 29 Jul 2013 18:17:39 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6T8HTN95308904 for ; Mon, 29 Jul 2013 18:17:29 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6T8HdpS020240 for ; Mon, 29 Jul 2013 18:17:39 +1000 Message-ID: <51F6251D.3000506@linux.vnet.ibm.com> Date: Mon, 29 Jul 2013 16:17:33 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374765505-14356-1-git-send-email-stefanha@redhat.com> <1374765505-14356-10-git-send-email-stefanha@redhat.com> In-Reply-To: <1374765505-14356-10-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 09/18] block/iscsi: drop iscsi_process_flush() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Ping Fan Liu , qemu-devel@nongnu.org, Michael Roth , alex@alex.org.uk, Paolo Bonzini Reviewed-by: Wenchao Xia > .io_flush() is no longer called so drop iscsi_process_flush(). > > Signed-off-by: Stefan Hajnoczi > --- > block/iscsi.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 5f28c6a..e2692d6 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -146,13 +146,6 @@ static const AIOCBInfo iscsi_aiocb_info = { > static void iscsi_process_read(void *arg); > static void iscsi_process_write(void *arg); > > -static int iscsi_process_flush(void *arg) > -{ > - IscsiLun *iscsilun = arg; > - > - return iscsi_queue_length(iscsilun->iscsi) > 0; > -} > - > static void > iscsi_set_events(IscsiLun *iscsilun) > { > @@ -166,7 +159,7 @@ iscsi_set_events(IscsiLun *iscsilun) > qemu_aio_set_fd_handler(iscsi_get_fd(iscsi), > iscsi_process_read, > (ev & POLLOUT) ? iscsi_process_write : NULL, > - iscsi_process_flush, > + NULL, > iscsilun); > > } > -- Best Regards Wenchao Xia