From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3im1-0003Zy-40 for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:25:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3ilr-0005Kh-QL for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:25:44 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:54143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3ilq-0005KO-Qz for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:25:35 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2013 18:22:29 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 1A9B12BB0053 for ; Mon, 29 Jul 2013 18:25:29 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6T89o9a64880850 for ; Mon, 29 Jul 2013 18:09:50 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6T8PSt5000943 for ; Mon, 29 Jul 2013 18:25:28 +1000 Message-ID: <51F626F2.4030101@linux.vnet.ibm.com> Date: Mon, 29 Jul 2013 16:25:22 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374765505-14356-1-git-send-email-stefanha@redhat.com> <1374765505-14356-15-git-send-email-stefanha@redhat.com> In-Reply-To: <1374765505-14356-15-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Ping Fan Liu , qemu-devel@nongnu.org, Michael Roth , alex@alex.org.uk, Paolo Bonzini Reviewed-by: Wenchao Xia > .io_flush() is no longer called so drop return_true(). > > Signed-off-by: Stefan Hajnoczi > --- > block/ssh.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/block/ssh.c b/block/ssh.c > index d7e7bf8..e149da9 100644 > --- a/block/ssh.c > +++ b/block/ssh.c > @@ -740,14 +740,6 @@ static void restart_coroutine(void *opaque) > qemu_coroutine_enter(co, NULL); > } > > -/* Always true because when we have called set_fd_handler there is > - * always a request being processed. > - */ > -static int return_true(void *opaque) > -{ > - return 1; > -} > - > static coroutine_fn void set_fd_handler(BDRVSSHState *s) > { > int r; > @@ -766,7 +758,7 @@ static coroutine_fn void set_fd_handler(BDRVSSHState *s) > DPRINTF("s->sock=%d rd_handler=%p wr_handler=%p", s->sock, > rd_handler, wr_handler); > > - qemu_aio_set_fd_handler(s->sock, rd_handler, wr_handler, return_true, co); > + qemu_aio_set_fd_handler(s->sock, rd_handler, wr_handler, NULL, co); > } > > static coroutine_fn void clear_fd_handler(BDRVSSHState *s) > -- Best Regards Wenchao Xia