From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3itS-0007PO-7B for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:33:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3itH-0007LV-TW for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:33:26 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:41734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3itH-0007L3-9B for qemu-devel@nongnu.org; Mon, 29 Jul 2013 04:33:15 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2013 13:57:16 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 3AC2E1258043 for ; Mon, 29 Jul 2013 14:02:36 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6T8Y7sL26083456 for ; Mon, 29 Jul 2013 14:04:07 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6T8X6Ye009949 for ; Mon, 29 Jul 2013 18:33:07 +1000 Message-ID: <51F628BE.7080505@linux.vnet.ibm.com> Date: Mon, 29 Jul 2013 16:33:02 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374765505-14356-1-git-send-email-stefanha@redhat.com> <1374765505-14356-17-git-send-email-stefanha@redhat.com> In-Reply-To: <1374765505-14356-17-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 16/18] thread-pool: drop thread_pool_active() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Ping Fan Liu , qemu-devel@nongnu.org, Michael Roth , alex@alex.org.uk, Paolo Bonzini Reviewed-by: Wenchao Xia > .io_flush() is no longer called so drop thread_pool_active(). The block > layer is the only thread-pool.c user and it already tracks in-flight > requests, therefore we do not need thread_pool_active(). > > Signed-off-by: Stefan Hajnoczi > --- > thread-pool.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/thread-pool.c b/thread-pool.c > index 0ebd4c2..096f007 100644 > --- a/thread-pool.c > +++ b/thread-pool.c > @@ -197,12 +197,6 @@ restart: > } > } > > -static int thread_pool_active(EventNotifier *notifier) > -{ > - ThreadPool *pool = container_of(notifier, ThreadPool, notifier); > - return !QLIST_EMPTY(&pool->head); > -} > - > static void thread_pool_cancel(BlockDriverAIOCB *acb) > { > ThreadPoolElement *elem = (ThreadPoolElement *)acb; > @@ -310,7 +304,7 @@ static void thread_pool_init_one(ThreadPool *pool, AioContext *ctx) > QTAILQ_INIT(&pool->request_list); > > aio_set_event_notifier(ctx, &pool->notifier, event_notifier_ready, > - thread_pool_active); > + NULL); > } > > ThreadPool *thread_pool_new(AioContext *ctx) > -- Best Regards Wenchao Xia