From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3mMe-0006wf-M2
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 08:15:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3mMZ-0000ud-LU
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 08:15:48 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35227 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3mMZ-0000tN-CU
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 08:15:43 -0400
Message-ID: <51F65CE4.1040501@suse.de>
Date: Mon, 29 Jul 2013 14:15:32 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1374889807-21069-1-git-send-email-afaerber@suse.de>
	<51F65849.4030107@ilande.co.uk>
In-Reply-To: <51F65849.4030107@ilande.co.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence
	for SUNW, fdtwo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: blauwirbel@gmail.com, Hu Tao <hutao@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>

Am 29.07.2013 13:55, schrieb Mark Cave-Ayland:
> On 27/07/13 02:50, Andreas F=C3=A4rber wrote:
>=20
>> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's
>> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539)
>> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than
>> SUNW,fdtwo.
>>
>> Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an
>> abstract type base-sysbus-fdc.
>>
>> This allows to consolidate realizefns by using instance_init functions=
.
>> Clean up variable names and variable order while at it.
>>
>> Reported-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
>> Cc: Hu Tao<hutao@cn.fujitsu.com>
>> Signed-off-by: Andreas F=C3=A4rber<afaerber@suse.de>
>=20
> Hi Andreas,
>=20
> I can confirm that this fixes SPARC32 for me - thanks!
>=20
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Thanks. Can you give my latest qom-devices branch a whirl, too?
I started adding trivial qtests for machines, but only covering the
default machines without -fda etc.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg