From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3nFR-0002jM-RZ for qemu-devel@nongnu.org; Mon, 29 Jul 2013 09:12:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3nFJ-0004M5-EV for qemu-devel@nongnu.org; Mon, 29 Jul 2013 09:12:25 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:33760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3nFJ-0004Lz-8M for qemu-devel@nongnu.org; Mon, 29 Jul 2013 09:12:17 -0400 Received: by mail-wi0-f169.google.com with SMTP id f14so836060wiw.0 for ; Mon, 29 Jul 2013 06:12:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51F66A1D.2020409@redhat.com> Date: Mon, 29 Jul 2013 15:11:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1375067768-11342-1-git-send-email-pingfank@linux.vnet.ibm.com> <1375067768-11342-5-git-send-email-pingfank@linux.vnet.ibm.com> <51F60C64.30908@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 4/5] timer: associate three timerlists with AioContext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: Kevin Wolf , Stefan Hajnoczi , Jan Kiszka , qemu-devel@nongnu.org, Alex Bligh , Anthony Liguori Il 29/07/2013 10:20, liu ping fan ha scritto: >> > Another issue is that deadline computation is not using the AioContext's >> > timer lists. >> > > Sorry, can not catch the meaning. When AioContext has its own timer > lists, it will have its own deadline(for ppoll timeout). So the > computation should be based on AioContext's timer lists, right? Associating the main loop's timer lists to other AioContexts is really really wrong... It is _already_ wrong to run timers in the main AioContext's aio_poll (because timers may not be ready to run from an arbitrary aio_poll), it is even worse to run them in other threads without taking the BQL. What exactly is the purpose of this series? Paolo