From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3o3d-0002uu-Tw for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3o3Y-00048o-LG for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:04:17 -0400 Message-ID: <51F67643.4030108@redhat.com> Date: Mon, 29 Jul 2013 16:03:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374762197-7261-1-git-send-email-pbonzini@redhat.com> <1374762197-7261-8-git-send-email-pbonzini@redhat.com> <20130729134349.GI10467@dhcp-200-207.str.redhat.com> In-Reply-To: <20130729134349.GI10467@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org Il 29/07/2013 15:43, Kevin Wolf ha scritto: > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: >> Some bdrv_is_allocated callers do not expect errors, but the fallback >> in qcow2.c might make other callers trip on assertion failures or >> infinite loops. >> >> Fix the callers to always look for errors. >> >> Cc: qemu-stable@nongnu.org >> Reviewed-by: Eric Blake >> Signed-off-by: Paolo Bonzini > > Good idea, but there seem to be a few more callers that don't handle > errors yet. Not sure what your criterion for fixing callers or not was. > Did you simply miss the rest? In general, I didn't bother about callers that didn't handle *pnum = 0 correctly (for example block-migration.c and commit). But I see now that the ones in qemu-io-cmds.c are due to a bad rebase. (BTW, I just noticed now that both block-migration.c and commit also run outside a coroutine, and thus rely on bdrv_is_allocated creating one). Paolo