From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3ov3-0002wu-O0 for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:59:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3oux-0005wX-TV for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:59:29 -0400 Received: from mout.web.de ([212.227.15.4]:56805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3oux-0005w9-KM for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:59:23 -0400 Received: from envy.site ([195.135.221.2]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0Maazp-1Uolw80yoz-00KBj3 for ; Mon, 29 Jul 2013 16:59:21 +0200 Message-ID: <51F68347.409@web.de> Date: Mon, 29 Jul 2013 16:59:19 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1373988662-19211-1-git-send-email-pbonzini@redhat.com> <1373988662-19211-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1373988662-19211-4-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , jan.kiszka@siemens.com Cc: Anthony Liguori , peter.maydell@linaro.org, =?ISO-8859-15?Q?Herv=E9_Poussineau?= , qemu-devel@nongnu.org, stefanha@redhat.com Am 16.07.2013 17:31, schrieb Paolo Bonzini: > From: Jan Kiszka > > This restore the behavior prior to b018ddf633 which accidentally changed > the return code to 0. Specifically guests probing for register existence > were affected by this. > > Signed-off-by: Jan Kiszka > Signed-off-by: Paolo Bonzini Unfortunately this negatively affects PReP: OpenHack'Ware booting Debian Etch prints: ERROR: WIN_READ_NATIVE_MAX : status 50 != 0x40 It does continue if one is patient enough. No problems before this commit. Any ideas, except that OHW may be doing Bad Things? Andreas > --- > memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/memory.c b/memory.c > index 9938b6b..34a088e 100644 > --- a/memory.c > +++ b/memory.c > @@ -840,7 +840,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, > if (current_cpu != NULL) { > cpu_unassigned_access(current_cpu, addr, false, false, 0, size); > } > - return 0; > + return -1ULL; > } > > static void unassigned_mem_write(void *opaque, hwaddr addr, >