From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: peter.maydell@linaro.org, stefanha@redhat.com,
qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions
Date: Mon, 29 Jul 2013 17:01:37 +0200 [thread overview]
Message-ID: <51F683D1.7010006@siemens.com> (raw)
In-Reply-To: <51F68347.409@web.de>
On 2013-07-29 16:59, Andreas Färber wrote:
> Am 16.07.2013 17:31, schrieb Paolo Bonzini:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This restore the behavior prior to b018ddf633 which accidentally changed
>> the return code to 0. Specifically guests probing for register existence
>> were affected by this.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Unfortunately this negatively affects PReP: OpenHack'Ware booting Debian
> Etch prints:
>
> ERROR: WIN_READ_NATIVE_MAX : status 50 != 0x40
>
> It does continue if one is patient enough.
> No problems before this commit.
>
> Any ideas, except that OHW may be doing Bad Things?
Which accesses return different results now, PIO or MMIO? What did they
return prior to b018ddf633?
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2013-07-29 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 15:30 [Qemu-devel] [PATCH for-1.6 0/3] Memory API fixes Paolo Bonzini
2013-07-16 15:31 ` [Qemu-devel] [PATCH 1/3] exec.c: Pass correct pointer type to qemu_ram_ptr_length Paolo Bonzini
2013-07-16 15:31 ` [Qemu-devel] [PATCH 2/3] memory: actually set the owner Paolo Bonzini
2013-07-17 2:32 ` Hu Tao
2013-07-16 15:31 ` [Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions Paolo Bonzini
2013-07-29 14:59 ` Andreas Färber
2013-07-29 15:01 ` Jan Kiszka [this message]
2013-07-29 15:04 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F683D1.7010006@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).