From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3wpK-0001lz-OH
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 19:26:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3wpF-0005VB-CM
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 19:26:06 -0400
Message-ID: <51F6FA01.2010305@suse.de>
Date: Tue, 30 Jul 2013 01:25:53 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370629140-30841-1-git-send-email-afaerber@suse.de>
	<1370629140-30841-5-git-send-email-afaerber@suse.de>
In-Reply-To: <1370629140-30841-5-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for
 virtserialport, too
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-stable@nongnu.org, jlarrew@linux.vnet.ibm.com, qemu-devel@nongnu.org, Amit Shah <amit.shah@redhat.com>, fred.konrad@greensocs.com

Michael, Anthony,

Am 07.06.2013 20:18, schrieb Andreas F=C3=A4rber:
> virtconsole and virtserialport are identical in every other aspect
> except for the distinguishing VirtIOSerialPortClass::is_console field.
>=20
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  hw/char/virtio-console.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
> index 7b1a382..73e18f2 100644
> --- a/hw/char/virtio-console.c
> +++ b/hw/char/virtio-console.c
> @@ -192,6 +192,7 @@ static void virtserialport_class_init(ObjectClass *=
klass, void *data)
>      VirtIOSerialPortClass *k =3D VIRTIO_SERIAL_PORT_CLASS(klass);
> =20
>      k->init =3D virtconsole_initfn;
> +    k->exit =3D virtconsole_exitfn;
>      k->have_data =3D flush_buf;
>      k->set_guest_connected =3D set_guest_connected;
>      dc->props =3D virtserialport_properties;

Ping! Is this a fix we should get into 1.6? Or does it not matter in
practice for some reason?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg