From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Bt9-0005cm-FG for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4Bt4-0000I5-Bq for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:31:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Bt4-0000Hu-4Q for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:30:58 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UFUvUc001609 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 11:30:57 -0400 Message-ID: <51F7DC2F.1040306@redhat.com> Date: Tue, 30 Jul 2013 17:30:55 +0200 From: Michal Novotny MIME-Version: 1.0 References: <87ppu06psb.fsf@blackfin.pond.sub.org> In-Reply-To: <87ppu06psb.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Hi Markus, should I rebase it or no need and can maintainer do it before push? Michal On 07/30/2013 05:17 PM, Markus Armbruster wrote: > Michal Novotny writes: > >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is >> when you upgrade from one version of qemu to another version that >> doesn't support required machine type any longer. > Text from here > >> The patch is checked using ./scripts/checkpatch.pl script and >> also is_help_option() function is being used. >> >> Michal > to here belongs below the '---' line, so it's ommitted from the commit > message. > >> Signed-off-by: Michal Novotny >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index 25b8f2f..563ae67 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >> if (machine) { >> return machine; >> } >> + >> + if (name && !is_help_option(name)) { >> + printf("Error: Unsupported machine type '%s'\n", name); >> + } >> + >> printf("Supported machines are:\n"); >> for (m = first_machine; m != NULL; m = m->next) { >> if (m->alias) { -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org