From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4CA9-0006Rp-18 for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4CA2-0006aX-2O for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:48:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4CA1-0006aL-QR for qemu-devel@nongnu.org; Tue, 30 Jul 2013 11:48:29 -0400 Message-ID: <51F7E045.4070206@redhat.com> Date: Tue, 30 Jul 2013 09:48:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374762197-7261-1-git-send-email-pbonzini@redhat.com> <1374762197-7261-15-git-send-email-pbonzini@redhat.com> In-Reply-To: <1374762197-7261-15-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JSTeuBOTW5NLs2LoBO1n6BekACpT9gtLK" Subject: Re: [Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JSTeuBOTW5NLs2LoBO1n6BekACpT9gtLK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2013 08:23 AM, Paolo Bonzini wrote: > Eric Blake also requested including the output in qapi-schema.json, > so that it is published through the introspection mechanism. >=20 > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 29 +++++++++++++++++++++++++++++ > qemu-img.texi | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 75 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -803,6 +803,35 @@ > { 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ]= } > =20 > ## > +# @BlockDeviceMapEntry: > +# > +# Entry in the metadata map of the device (returned by "qemu-img map")= Thanks for also referencing where this type is relevant (if we later add a QMP command that also exposes the map via this type, we would remove the parenthetical comment at that time). > +# > +# Since 1.6 Are we still shooting for 1.6, or has this missed the freeze? > =20 > +@item map [-f @var{fmt}] [--output=3D@var{ofmt}] @var{filename} > + > +Dump the metadata of image @var{filename} and its backing file chain. > +In particular, this commands dumps the allocation state of every secto= r s/commands/command/ > +of @var{filename}, together with the topmost file that allocates it in= > +the backing file chain. > + > +Two option formats are possible. The default format (@code{human}) > +only dumps known-nonzero areas of the file. Known-zero parts of the > +file are omitted altogether, and likewise for parts that are not alloc= ated > +throughout the chain. @command{qemu-img} output will identify a file > +from where the data can be read, and the offset in the file. Each lin= e > +will include four fields; for example: > +@example > +0 131072 2 327680 > +@end example > +@noindent > +means that 131072 bytes starting at offset 0 in the image are availabl= e at > +depth 2 (i.e. by opening in @code{raw} format the backing file of the > +backing file of @var{filename}) starting at offset 327680. Data that > +is compressed, encrypted, or otherwise not available in raw format wil= l > +cause an error if @code{human} format is in use. In case of a hybrid file (part raw, part encrypted), does this command exit on first error, or only after printing as much raw information was available? That is, even if we can't describe the entire allocation map, it may still be useful to dump as much information as possible before declaring that more data is inaccessible via raw mapping. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JSTeuBOTW5NLs2LoBO1n6BekACpT9gtLK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR9+BFAAoJEKeha0olJ0Nq7ZQH/A8nmxqJ7CMlhdnxGahbLkPm DX0TaYC2tOPSNnP6O8P+0Yd6jShvnBbOOWQ+D7dox7FpZ4QCFq9VVr2h1SQ//50F MaRv4Nc1wKIrBRY20QZNbeNmhPA1EcThODDqUlhVI/nYeLNB/MNkjv4hpPnd2vLP cXEbMINJR09okhq2CCIgVhDqfbQGAdef+BMDVCN6aiLLcFzmF0pKyWsdRzlJoF1y KdkQdAhiwroe12g+D34/z5N3HYxp6u2GzJ57DvvMmxyxC937Ekb7rVQH2qFbqe0y NX3bCOYa2PRGFXHzI87VFZwgI+3cKeyglVNvD4u64j3jNatzlxEjbk7dETtU+W8= =5Uvz -----END PGP SIGNATURE----- --JSTeuBOTW5NLs2LoBO1n6BekACpT9gtLK--