From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Fbv-0005Jz-HS for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:29:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4Fbo-0006Cc-Se for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:29:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Fbo-0006CL-Kd for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:29:24 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UJTNfI027835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 15:29:23 -0400 Message-ID: <51F81412.10809@redhat.com> Date: Tue, 30 Jul 2013 13:29:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <7f847cb5fd7c350e1460df5772c5a0481bc77b3c.1375211373.git.minovotn@redhat.com> In-Reply-To: <7f847cb5fd7c350e1460df5772c5a0481bc77b3c.1375211373.git.minovotn@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qI4GW3CJSDWBLLJocPoFJ7bViMWM42853" Subject: Re: [Qemu-devel] [PATCH v3] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qI4GW3CJSDWBLLJocPoFJ7bViMWM42853 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/30/2013 01:10 PM, Michal Novotny wrote: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer. I know that has historically happened downstream (for example, Fedora 13 made the mistake of creating a downstream-only fedora-13 machine type that corresponded roughly to qemu 0.13, it took some further Fedora patches to libvirt to modernize that name back to an upstream machine type on an upgrade path before finally being able to drop the downstream nonsense in Fedora 18 or so). But isn't upstream qemu supposed to be guaranteeing command-line stability, in that a newer qemu will never take away a machine type supported by an older qemu? But even if the upstream upgrade path never hits this code, your patch will make it nicer if you _downgrade_ to a version of qemu (still with this patch, of course) that lacks support for a newer machine. And the fact that downstream will take advantage of this even if upstream never causes the problem on upgrades still justifies using it. >=20 > Signed-off-by: Michal Novotny >=20 > --- > The patch is checked using ./scripts/checkpatch.pl script and > also is_help_option() function is being used. > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qI4GW3CJSDWBLLJocPoFJ7bViMWM42853 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR+BQSAAoJEKeha0olJ0NqluQH/2gpAPy8RIQWFOVWdXBLypqq rR5MpEP0Qeei35j3hti2RQESw8XmPc1kS5vcL/D7CCs4L0K40MjWqD1yU4qN63Sv h3l/hBaqE7FW2pRE+8qkqjr1h0UflDzmQgCYeQIkGpo++Qai3Ale7TOUp2cFSLX3 f8zGa2JP58p0pUVdNCUeHJdrynSSpt5GqtwucaqG9QRRn0H5+r/Ne8b2m56qqjyl hRmcktQ05IGSzTCSJdi6nPHWgTzpgABliyesEASwS1gFVeWzxQ+IEjBs3pO6pCn7 XGzrNo3l37cAQoKiifuvUO36aDhCwDObRu7hjiGEvy7sFnPuW88TNlYRF6q8EpU= =waoH -----END PGP SIGNATURE----- --qI4GW3CJSDWBLLJocPoFJ7bViMWM42853--