From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4QWp-0001Fh-Be for qemu-devel@nongnu.org; Wed, 31 Jul 2013 03:09:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4QWk-000425-0F for qemu-devel@nongnu.org; Wed, 31 Jul 2013 03:08:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4QJA-00078Z-7A for qemu-devel@nongnu.org; Wed, 31 Jul 2013 02:54:52 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6V6spnH008553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Jul 2013 02:54:51 -0400 Message-ID: <51F8B4BA.70209@redhat.com> Date: Wed, 31 Jul 2013 08:54:50 +0200 From: Michal Novotny MIME-Version: 1.0 References: <0e2ed0a9f48b8e6bbfbfa127e2e92c3d01b591fd.1375251985.git.minovotn@redhat.com> <87siyvns66.fsf@blackfin.pond.sub.org> In-Reply-To: <87siyvns66.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 07/31/2013 08:45 AM, Markus Armbruster wrote: > Michal Novotny writes: > >> Output error message to stderr when user provides the invalid machine >> type on the command line. This also saves time to find what issue is >> when you downgrade from one version of qemu to another that doesn't >> support required machine type yet (the version user downgraded to have >> to have this patch applied too, of course). >> >> Signed-off-by: Michal Novotny >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index f422a1c..6ee1a03 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >> if (machine) { >> return machine; >> } >> + >> + if (name && !is_help_option(name)) { >> + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); >> + } >> + >> printf("Supported machines are:\n"); >> for (m = first_machine; m != NULL; m = m->next) { >> if (m->alias) { > Sorry, should've looked more closely. Please use error_report() like > this: > > error_report("Unsupported machine type"); > > Improves the message from > > Error: Unsupported machine type 'HAL-9000' > > to the standard form > > qemu-system-x86_64: -M HAL-9000: Unsupported machine type That's nice qemu has this function, I didn't know. However, there are still some code parts that are not using error_report() as well, e.g. fprintf(stderr, "Error: standard VGA not available\n"); in the select_vgahw() function (line 2168) or: fprintf(stderr, "Failed to start VNC server on `%s': %s\n", vnc_display, error_get_pretty(local_err)); on line 4385 or: fprintf(stderr, "-incoming %s: %s\n", incoming, error_get_pretty(local_err)); on line 4428 (I've been looking just to vl.c file so far). Shouldn't all this be using error_report() as well? If so, a follow-up patch would be nice. Thanks, Michal -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org