From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4R6r-0000ip-IH for qemu-devel@nongnu.org; Wed, 31 Jul 2013 03:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4R6m-0002hg-6c for qemu-devel@nongnu.org; Wed, 31 Jul 2013 03:46:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41497 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4R6l-0002hS-VC for qemu-devel@nongnu.org; Wed, 31 Jul 2013 03:46:08 -0400 Message-ID: <51F8C0BB.5090401@suse.de> Date: Wed, 31 Jul 2013 09:46:03 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375208443-17288-1-git-send-email-rth@twiddle.net> <1375208443-17288-2-git-send-email-rth@twiddle.net> In-Reply-To: <1375208443-17288-2-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/2] qdev: Fix 32-bit compilation in print_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: vasilis.liaskovitis@profitbricks.com, imammedo@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Stefan Weil Anthony, Am 30.07.2013 20:20, schrieb Richard Henderson: > Signed-off-by: Richard Henderson FWIW Reviewed-by: Andreas F=E4rber This is a build fix, can you please review and apply 1/2? 2/2 was outside my quick understanding so I'm not sure. ;) rth, you forgot to mark it "for-1.6". Regards, Andreas > --- > hw/core/qdev-properties.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index 8d43a8d..d6d10c9 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -1177,7 +1177,7 @@ static int print_size(DeviceState *dev, Property = *prop, char *dest, size_t len) > int i =3D 0; > uint64_t div; > =20 > - for (div =3D (long int)1 << 40; !(*ptr / div) ; div >>=3D 10) { > + for (div =3D 1ULL << 40; !(*ptr / div) ; div >>=3D 10) { > i++; > } > return snprintf(dest, len, "%0.03f%c", (double)*ptr/div, suffixes[= i]); >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg