From: "Andreas Färber" <afaerber@suse.de>
To: Michal Novotny <minovotn@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided
Date: Wed, 31 Jul 2013 10:03:40 +0200 [thread overview]
Message-ID: <51F8C4DC.2090302@suse.de> (raw)
In-Reply-To: <51F8B4BA.70209@redhat.com>
Am 31.07.2013 08:54, schrieb Michal Novotny:
> there are
> still some code parts that are not using error_report() as well, e.g.
>
> fprintf(stderr, "Error: standard VGA not available\n");
>
> in the select_vgahw() function (line 2168) or:
>
> fprintf(stderr, "Failed to start VNC server on `%s': %s\n",
> vnc_display, error_get_pretty(local_err));
>
> on line 4385 or:
>
> fprintf(stderr, "-incoming %s: %s\n", incoming,
> error_get_pretty(local_err));
>
> on line 4428 (I've been looking just to vl.c file so far).
>
> Shouldn't all this be using error_report() as well? If so, a follow-up
> patch would be nice.
See http://patchwork.ozlabs.org/patch/260801/ for a start. :)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-31 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 6:30 [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided Michal Novotny
2013-07-31 6:45 ` Markus Armbruster
2013-07-31 6:54 ` Michal Novotny
2013-07-31 7:56 ` Markus Armbruster
2013-07-31 8:03 ` Andreas Färber [this message]
2013-07-31 7:05 ` Michal Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8C4DC.2090302@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=minovotn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).