* [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided @ 2013-07-31 6:30 Michal Novotny 2013-07-31 6:45 ` Markus Armbruster 0 siblings, 1 reply; 6+ messages in thread From: Michal Novotny @ 2013-07-31 6:30 UTC (permalink / raw) To: qemu-devel Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded to have to have this patch applied too, of course). Signed-off-by: Michal Novotny <minovotn@redhat.com> --- vl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index f422a1c..6ee1a03 100644 --- a/vl.c +++ b/vl.c @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) if (machine) { return machine; } + + if (name && !is_help_option(name)) { + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); + } + printf("Supported machines are:\n"); for (m = first_machine; m != NULL; m = m->next) { if (m->alias) { -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided 2013-07-31 6:30 [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided Michal Novotny @ 2013-07-31 6:45 ` Markus Armbruster 2013-07-31 6:54 ` Michal Novotny 2013-07-31 7:05 ` Michal Novotny 0 siblings, 2 replies; 6+ messages in thread From: Markus Armbruster @ 2013-07-31 6:45 UTC (permalink / raw) To: Michal Novotny; +Cc: qemu-devel Michal Novotny <minovotn@redhat.com> writes: > Output error message to stderr when user provides the invalid machine > type on the command line. This also saves time to find what issue is > when you downgrade from one version of qemu to another that doesn't > support required machine type yet (the version user downgraded to have > to have this patch applied too, of course). > > Signed-off-by: Michal Novotny <minovotn@redhat.com> > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/vl.c b/vl.c > index f422a1c..6ee1a03 100644 > --- a/vl.c > +++ b/vl.c > @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) > if (machine) { > return machine; > } > + > + if (name && !is_help_option(name)) { > + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); > + } > + > printf("Supported machines are:\n"); > for (m = first_machine; m != NULL; m = m->next) { > if (m->alias) { Sorry, should've looked more closely. Please use error_report() like this: error_report("Unsupported machine type"); Improves the message from Error: Unsupported machine type 'HAL-9000' to the standard form qemu-system-x86_64: -M HAL-9000: Unsupported machine type ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided 2013-07-31 6:45 ` Markus Armbruster @ 2013-07-31 6:54 ` Michal Novotny 2013-07-31 7:56 ` Markus Armbruster 2013-07-31 8:03 ` Andreas Färber 2013-07-31 7:05 ` Michal Novotny 1 sibling, 2 replies; 6+ messages in thread From: Michal Novotny @ 2013-07-31 6:54 UTC (permalink / raw) To: Markus Armbruster; +Cc: qemu-devel On 07/31/2013 08:45 AM, Markus Armbruster wrote: > Michal Novotny <minovotn@redhat.com> writes: > >> Output error message to stderr when user provides the invalid machine >> type on the command line. This also saves time to find what issue is >> when you downgrade from one version of qemu to another that doesn't >> support required machine type yet (the version user downgraded to have >> to have this patch applied too, of course). >> >> Signed-off-by: Michal Novotny <minovotn@redhat.com> >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index f422a1c..6ee1a03 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >> if (machine) { >> return machine; >> } >> + >> + if (name && !is_help_option(name)) { >> + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); >> + } >> + >> printf("Supported machines are:\n"); >> for (m = first_machine; m != NULL; m = m->next) { >> if (m->alias) { > Sorry, should've looked more closely. Please use error_report() like > this: > > error_report("Unsupported machine type"); > > Improves the message from > > Error: Unsupported machine type 'HAL-9000' > > to the standard form > > qemu-system-x86_64: -M HAL-9000: Unsupported machine type That's nice qemu has this function, I didn't know. However, there are still some code parts that are not using error_report() as well, e.g. fprintf(stderr, "Error: standard VGA not available\n"); in the select_vgahw() function (line 2168) or: fprintf(stderr, "Failed to start VNC server on `%s': %s\n", vnc_display, error_get_pretty(local_err)); on line 4385 or: fprintf(stderr, "-incoming %s: %s\n", incoming, error_get_pretty(local_err)); on line 4428 (I've been looking just to vl.c file so far). Shouldn't all this be using error_report() as well? If so, a follow-up patch would be nice. Thanks, Michal -- Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided 2013-07-31 6:54 ` Michal Novotny @ 2013-07-31 7:56 ` Markus Armbruster 2013-07-31 8:03 ` Andreas Färber 1 sibling, 0 replies; 6+ messages in thread From: Markus Armbruster @ 2013-07-31 7:56 UTC (permalink / raw) To: Michal Novotny; +Cc: qemu-devel Michal Novotny <minovotn@redhat.com> writes: > On 07/31/2013 08:45 AM, Markus Armbruster wrote: >> Michal Novotny <minovotn@redhat.com> writes: >> >>> Output error message to stderr when user provides the invalid machine >>> type on the command line. This also saves time to find what issue is >>> when you downgrade from one version of qemu to another that doesn't >>> support required machine type yet (the version user downgraded to have >>> to have this patch applied too, of course). >>> >>> Signed-off-by: Michal Novotny <minovotn@redhat.com> >>> --- >>> vl.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/vl.c b/vl.c >>> index f422a1c..6ee1a03 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >>> if (machine) { >>> return machine; >>> } >>> + >>> + if (name && !is_help_option(name)) { >>> + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); >>> + } >>> + >>> printf("Supported machines are:\n"); >>> for (m = first_machine; m != NULL; m = m->next) { >>> if (m->alias) { >> Sorry, should've looked more closely. Please use error_report() like >> this: >> >> error_report("Unsupported machine type"); >> >> Improves the message from >> >> Error: Unsupported machine type 'HAL-9000' >> >> to the standard form >> >> qemu-system-x86_64: -M HAL-9000: Unsupported machine type > > That's nice qemu has this function, I didn't know. However, there are > still some code parts that are not using error_report() as well, e.g. > > fprintf(stderr, "Error: standard VGA not available\n"); > > in the select_vgahw() function (line 2168) or: > > fprintf(stderr, "Failed to start VNC server on `%s': %s\n", > vnc_display, error_get_pretty(local_err)); > > on line 4385 or: > > fprintf(stderr, "-incoming %s: %s\n", incoming, > error_get_pretty(local_err)); > > on line 4428 (I've been looking just to vl.c file so far). Lots of them, all over the place. > Shouldn't all this be using error_report() as well? If so, a follow-up > patch would be nice. As usual, patches welcome :) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided 2013-07-31 6:54 ` Michal Novotny 2013-07-31 7:56 ` Markus Armbruster @ 2013-07-31 8:03 ` Andreas Färber 1 sibling, 0 replies; 6+ messages in thread From: Andreas Färber @ 2013-07-31 8:03 UTC (permalink / raw) To: Michal Novotny; +Cc: Markus Armbruster, qemu-devel Am 31.07.2013 08:54, schrieb Michal Novotny: > there are > still some code parts that are not using error_report() as well, e.g. > > fprintf(stderr, "Error: standard VGA not available\n"); > > in the select_vgahw() function (line 2168) or: > > fprintf(stderr, "Failed to start VNC server on `%s': %s\n", > vnc_display, error_get_pretty(local_err)); > > on line 4385 or: > > fprintf(stderr, "-incoming %s: %s\n", incoming, > error_get_pretty(local_err)); > > on line 4428 (I've been looking just to vl.c file so far). > > Shouldn't all this be using error_report() as well? If so, a follow-up > patch would be nice. See http://patchwork.ozlabs.org/patch/260801/ for a start. :) Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided 2013-07-31 6:45 ` Markus Armbruster 2013-07-31 6:54 ` Michal Novotny @ 2013-07-31 7:05 ` Michal Novotny 1 sibling, 0 replies; 6+ messages in thread From: Michal Novotny @ 2013-07-31 7:05 UTC (permalink / raw) To: Markus Armbruster; +Cc: qemu-devel On 07/31/2013 08:45 AM, Markus Armbruster wrote: > Michal Novotny <minovotn@redhat.com> writes: > >> Output error message to stderr when user provides the invalid machine >> type on the command line. This also saves time to find what issue is >> when you downgrade from one version of qemu to another that doesn't >> support required machine type yet (the version user downgraded to have >> to have this patch applied too, of course). >> >> Signed-off-by: Michal Novotny <minovotn@redhat.com> >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index f422a1c..6ee1a03 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >> if (machine) { >> return machine; >> } >> + >> + if (name && !is_help_option(name)) { >> + fprintf(stderr, "Error: Unsupported machine type '%s'\n", name); >> + } >> + >> printf("Supported machines are:\n"); >> for (m = first_machine; m != NULL; m = m->next) { >> if (m->alias) { > Sorry, should've looked more closely. Please use error_report() like > this: > > error_report("Unsupported machine type"); > > Improves the message from > > Error: Unsupported machine type 'HAL-9000' > > to the standard form > > qemu-system-x86_64: -M HAL-9000: Unsupported machine type FYI: v5 has been sent using the error_report() Michal > -- Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-31 9:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-31 6:30 [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided Michal Novotny 2013-07-31 6:45 ` Markus Armbruster 2013-07-31 6:54 ` Michal Novotny 2013-07-31 7:56 ` Markus Armbruster 2013-07-31 8:03 ` Andreas Färber 2013-07-31 7:05 ` Michal Novotny
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).