From: Gerd Hoffmann <kraxel@redhat.com>
To: Martin Cerveny <M.Cerveny@computer.org>
Cc: qemu-devel@nongnu.org, Martin Cerveny <martin@c-home.cz>
Subject: Re: [Qemu-devel] [PATCH] hw/usb/redirect.c: crash in QOM cleanup
Date: Wed, 31 Jul 2013 11:21:37 +0200 [thread overview]
Message-ID: <51F8D721.8060806@redhat.com> (raw)
In-Reply-To: <alpine.GSO.2.00.1307281727010.22152@dmz.c-home.cz>
Hi,
> diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
> index a594e95..1c62263 100644
> --- a/hw/usb/redirect.c
> +++ b/hw/usb/redirect.c
> @@ -1334,6 +1334,7 @@ static void usbredir_handle_destroy(USBDevice *udev)
> USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev);
>
> qemu_chr_delete(dev->cs);
> + dev->cs = NULL;
> /* Note must be done after qemu_chr_close, as that causes a close
> event */
> qemu_bh_delete(dev->chardev_close_bh);
Patch doesn't apply, probably because it is whitespace-mangled. Redid
it. Please use 'git send-email' to send patches in the future, it is
more robust.
cheers,
Gerd
prev parent reply other threads:[~2013-07-31 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 15:47 [Qemu-devel] [PATCH] hw/usb/redirect.c: crash in QOM cleanup Martin Cerveny
2013-07-31 9:21 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8D721.8060806@redhat.com \
--to=kraxel@redhat.com \
--cc=M.Cerveny@computer.org \
--cc=martin@c-home.cz \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).