From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V4SbW-000878-Bw
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:22:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V4SbQ-0001jQ-Dp
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:21:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1V4SbP-0001jH-VY
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 05:21:52 -0400
Message-ID: <51F8D721.8060806@redhat.com>
Date: Wed, 31 Jul 2013 11:21:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <alpine.GSO.2.00.1307281727010.22152@dmz.c-home.cz>
In-Reply-To: <alpine.GSO.2.00.1307281727010.22152@dmz.c-home.cz>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/usb/redirect.c: crash in QOM cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Martin Cerveny <M.Cerveny@computer.org>
Cc: qemu-devel@nongnu.org, Martin Cerveny <martin@c-home.cz>

  Hi,

> diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
> index a594e95..1c62263 100644
> --- a/hw/usb/redirect.c
> +++ b/hw/usb/redirect.c
> @@ -1334,6 +1334,7 @@ static void usbredir_handle_destroy(USBDevice *udev)
>      USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev);
> 
>      qemu_chr_delete(dev->cs);
> +    dev->cs = NULL;
>      /* Note must be done after qemu_chr_close, as that causes a close
> event */
>      qemu_bh_delete(dev->chardev_close_bh);

Patch doesn't apply, probably because it is whitespace-mangled.  Redid
it.  Please use 'git send-email' to send patches in the future, it is
more robust.

cheers,
  Gerd