From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1V4UAO-0006Z6-Kc
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:02:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1V4UAK-0003CS-1M
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:02:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1V4UAJ-0003CC-Qg
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:01:59 -0400
Message-ID: <51F8EF28.1000904@redhat.com>
Date: Wed, 31 Jul 2013 13:04:08 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1375252936-28496-1-git-send-email-gaowanlong@cn.fujitsu.com>
	<1375252936-28496-2-git-send-email-gaowanlong@cn.fujitsu.com>
In-Reply-To: <1375252936-28496-2-git-send-email-gaowanlong@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V7 01/11] NUMA: add NumaOptions,
	NumaNodeOptions and NumaMemOptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, afaerber@suse.de

On 07/31/13 08:42, Wanlong Gao wrote:
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
>  qapi-schema.json | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a51f7d2..b9b18e4 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3773,3 +3773,50 @@
>  ##
>  { 'command': 'query-rx-filter', 'data': { '*name': 'str' },
>    'returns': ['RxFilterInfo'] }
> +
> +##
> +# @NumaOptions
> +#
> +# A discriminated record of NUMA options.
> +#
> +# Since 1.7
> +##
> +{ 'union': 'NumaOptions',
> +  'data': {
> +    'node': 'NumaNodeOptions',
> +    'mem':  'NumaMemOptions' }}
> +
> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @cpus: #optional VCPUs belong to this node
> +#
> +# @mem: #optional memory size of this node (remain as legacy)
> +#
> +# Since: 1.7
> +##
> +{ 'type': 'NumaNodeOptions',
> +  'data': {
> +   '*nodeid': 'uint16',
> +   '*cpus':   ['uint16'],
> +   '*mem':    'str' }}
> +
> +##
> +# @NumaMemOptions
> +#
> +# Set memory information of guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @size: #optional memory size of this node
> +#
> +# Since 1.7
> +##
> +{ 'type': 'NumaMemOptions',
> +  'data': {
> +   '*nodeid': 'uint16',
> +   '*size':   'size' }}
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(and you already have it on V7 02/11, good)

Thanks
Laszlo