From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Vincenzo Maffione <v.maffione@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Luigi Rizzo <rizzo@iet.unipi.it>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support
Date: Wed, 31 Jul 2013 13:26:35 +0200 [thread overview]
Message-ID: <51F8F46B.1060404@suse.de> (raw)
In-Reply-To: <20130731112024.GD28592@stefanha-thinkpad.muc.redhat.com>
Am 31.07.2013 13:20, schrieb Stefan Hajnoczi:
> On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote:
>> Sorry, I'm not confident with this infrastructure.
>
> Thanks for your efforts! Normally this change would not be necessary
> but you are the first person who needs a 1.6 compat property :).
>
>> So do you just want me to invert the commit order? (and do the other
>> two little changes)
>
> Yes, please introduce an empty PC_COMPAT_1_6 in Patch 1 and then make
> use of it for e1000 interrupt mitigation in Patch 2. That way creating
> PC_COMPAT_1_6 is an independent commit which can be cherry-picked and
> reused independently of e1000 interrupt mitigation.
Add to that, the patch needs to be amended to actually add 1.7 machines
for i440fx and q35, moving the .alias there instead of on the 1.6
machines. Otherwise mitigation will always be disabled. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-31 11:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:13 [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support Vincenzo Maffione
2013-07-31 8:13 ` [Qemu-devel] [PATCH v5 1/2] " Vincenzo Maffione
2013-07-31 10:05 ` Andreas Färber
2013-07-31 8:13 ` [Qemu-devel] [PATCH v5 2/2] i386/pc: introducing compat_props for pc-1.6 Vincenzo Maffione
2013-07-31 10:00 ` Andreas Färber
2013-07-31 9:56 ` [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support Andreas Färber
2013-07-31 10:19 ` Vincenzo Maffione
2013-07-31 11:20 ` Stefan Hajnoczi
2013-07-31 11:26 ` Andreas Färber [this message]
2013-07-31 13:39 ` Vincenzo Maffione
2013-08-01 9:38 ` Stefan Hajnoczi
2013-08-01 14:07 ` Andreas Färber
2013-08-01 20:17 ` Vincenzo Maffione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8F46B.1060404@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@redhat.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).