From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system
Date: Wed, 31 Jul 2013 14:03:56 +0200 [thread overview]
Message-ID: <51F8FD2C.1010002@suse.de> (raw)
In-Reply-To: <CAFEAcA8UZRQAv9NLRcyvUffXMKMM01FauUDvmxiGRwHJzmUM1g@mail.gmail.com>
Am 31.07.2013 13:05, schrieb Peter Maydell:
> On 31 July 2013 11:27, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 31.07.2013 14:24, Michael Tokarev wrote:
>>> Move qemu-ga build check out of if softmmu.. into if tools section.
>>> We want to build qemu-ga for _guest_ even if system build isn't
>>> done. It is controlled separately using --enable-guest-agent.
>>
>> Actually the more I think about it... Maybe it shouldn't depend
>> on --enable-tools either, but should be an independent option.
>> Because it isn't really a tool.
>
> This seems to me to be unnecessarily breaking things down
> into very finely divided categories. I think putting it
> in --enable-tools is fine.
I disagree. Think about building a Windows guest agent: You don't need
qemu-img (tools) on a Windows guest, and mjt is right that it shouldn't
be coupled to building any qemu-system-*.
However it looks as if the linux/bsd/solaris checks got lost in the patch?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-31 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 10:24 [Qemu-devel] [PATCH] qemu-ga: build it even if !system Michael Tokarev
2013-07-31 10:27 ` Michael Tokarev
2013-07-31 11:05 ` Peter Maydell
2013-07-31 12:03 ` Andreas Färber [this message]
2013-07-31 12:24 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8FD2C.1010002@suse.de \
--to=afaerber@suse.de \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).