From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57247)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4V8Q-0003xI-N7
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 08:04:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4V8K-0007MS-NA
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 08:04:06 -0400
Message-ID: <51F8FD2C.1010002@suse.de>
Date: Wed, 31 Jul 2013 14:03:56 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375266255-22207-1-git-send-email-mjt@msgid.tls.msk.ru>
	<51F8E68F.4030006@msgid.tls.msk.ru>
	<CAFEAcA8UZRQAv9NLRcyvUffXMKMM01FauUDvmxiGRwHJzmUM1g@mail.gmail.com>
In-Reply-To: <CAFEAcA8UZRQAv9NLRcyvUffXMKMM01FauUDvmxiGRwHJzmUM1g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

Am 31.07.2013 13:05, schrieb Peter Maydell:
> On 31 July 2013 11:27, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 31.07.2013 14:24, Michael Tokarev wrote:
>>> Move qemu-ga build check out of if softmmu.. into if tools section.
>>> We want to build qemu-ga for _guest_ even if system build isn't
>>> done.  It is controlled separately using --enable-guest-agent.
>>
>> Actually the more I think about it... Maybe it shouldn't depend
>> on --enable-tools either, but should be an independent option.
>> Because it isn't really a tool.
>=20
> This seems to me to be unnecessarily breaking things down
> into very finely divided categories. I think putting it
> in --enable-tools is fine.

I disagree. Think about building a Windows guest agent: You don't need
qemu-img (tools) on a Windows guest, and mjt is right that it shouldn't
be coupled to building any qemu-system-*.

However it looks as if the linux/bsd/solaris checks got lost in the patch=
?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg