From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1V4bbJ-0006xL-0J
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 14:58:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1V4a81-00062A-8s
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 13:24:11 -0400
Received: from mout.web.de ([212.227.15.14]:51285)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1V4a80-000613-TX
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 13:24:01 -0400
Received: from envy.site ([195.135.221.2]) by smtp.web.de (mrweb101) with
	ESMTPSA (Nemesis) id 0Laky4-1UKY3b3BRA-00kKkc for
	<qemu-devel@nongnu.org>; Wed, 31 Jul 2013 19:23:59 +0200
Message-ID: <51F9482F.1030207@web.de>
Date: Wed, 31 Jul 2013 19:23:59 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1374614206-9368-1-git-send-email-hpoussin@reactos.org>
	<1374614206-9368-3-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1374614206-9368-3-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Am 23.07.2013 23:16, schrieb Hervé Poussineau:
> diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
> index de71d81..f2045de 100644
> --- a/hw/isa/i82378.c
> +++ b/hw/isa/i82378.c
[...]
> -static const VMStateDescription vmstate_pci_i82378 = {
> -    .name = "pci-i82378",
> +static const VMStateDescription vmstate_i82378 = {
> +    .name = "i82378",
>      .version_id = 0,
>      .minimum_version_id = 0,
>      .fields = (VMStateField[]) {
> -        VMSTATE_PCI_DEVICE(pci_dev, PCIi82378State),
> +        VMSTATE_PCI_DEVICE(parent_obj, I82378State),
>          VMSTATE_END_OF_LIST()
>      },
>  };
[snip]

Renaming the section would break backwards compatibility, we'll need to
live with that name.

Andreas