From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50883)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1V4bbv-0007hc-50
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 14:59:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1V4bbk-00023i-UA
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 14:58:58 -0400
Message-ID: <51F95E5D.7050503@reactos.org>
Date: Wed, 31 Jul 2013 20:58:37 +0200
From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1374614206-9368-1-git-send-email-hpoussin@reactos.org>
	<1374614206-9368-3-git-send-email-hpoussin@reactos.org>
	<51F9482F.1030207@web.de>
In-Reply-To: <51F9482F.1030207@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Andreas F=C3=A4rber a =C3=A9crit :
> Am 23.07.2013 23:16, schrieb Herv=C3=A9 Poussineau:
>> diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
>> index de71d81..f2045de 100644
>> --- a/hw/isa/i82378.c
>> +++ b/hw/isa/i82378.c
> [...]
>> -static const VMStateDescription vmstate_pci_i82378 =3D {
>> -    .name =3D "pci-i82378",
>> +static const VMStateDescription vmstate_i82378 =3D {
>> +    .name =3D "i82378",
>>      .version_id =3D 0,
>>      .minimum_version_id =3D 0,
>>      .fields =3D (VMStateField[]) {
>> -        VMSTATE_PCI_DEVICE(pci_dev, PCIi82378State),
>> +        VMSTATE_PCI_DEVICE(parent_obj, I82378State),
>>          VMSTATE_END_OF_LIST()
>>      },
>>  };
> [snip]
>=20
> Renaming the section would break backwards compatibility, we'll need to
> live with that name.

Not a problem.
Or, you can update version_id and minimum_version_id to 1, and ignore=20
backward compatibility problems, as i82378 is only used in PPC machine=20
by default.
Do as you want.

Herv=C3=A9