From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V4jWC-0005lA-5L
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 23:25:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V4jWB-0006Ee-1I
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 23:25:36 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:42494
	helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1V4jWA-000652-Mm
	for qemu-devel@nongnu.org; Wed, 31 Jul 2013 23:25:34 -0400
Message-ID: <51F9D506.9040909@comstyle.com>
Date: Wed, 31 Jul 2013 23:24:54 -0400
From: Brad <brad@comstyle.com>
MIME-Version: 1.0
References: <1372841894-10634-1-git-send-email-tsutsui@ceres.dti.ne.jp>
	<51D3F1C2.5050609@redhat.com>
In-Reply-To: <51D3F1C2.5050609@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under
 load on NetBSD hosts.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>, qemu-devel@nongnu.org

On 03/07/13 5:41 AM, Laszlo Ersek wrote:
> On 07/03/13 10:58, Izumi Tsutsui wrote:
>> Fix following bugs in "fallback implementation of counting semaphores
>> with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976:
>>   - waiting threads are not restarted properly if more than one threads
>>     are waiting unblock signals in qemu_sem_timedwait()
>>   - possible missing pthread_cond_signal(3) calls when waiting threads
>>     are returned by ETIMEDOUT
>>   - fix an uninitialized variable
>> The problem is analyzed by and fix is provided by Noriyuki Soda.
>>
>> Also put additional cleanup suggested by Laszlo Ersek:
>>   - make QemuSemaphore.count unsigned (it won't be negative)
>>   - check a return value of in pthread_cond_wait() in qemu_sem_wait()
>>
>> Signed-off-by: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>>   v3:
>>   - fix a missed assignment and actually check a retval of pthread_cond_wait()
>
> Compared v3 against v2.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Laszlo

This patch seems to have been dropped.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.