From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4kYw-0005GL-7H for qemu-devel@nongnu.org; Thu, 01 Aug 2013 00:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4kYq-0002LW-2k for qemu-devel@nongnu.org; Thu, 01 Aug 2013 00:32:30 -0400 Message-ID: <51F9E4D4.4090405@weilnetz.de> Date: Thu, 01 Aug 2013 06:32:20 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1375305626-26972-1-git-send-email-rjones@redhat.com> In-Reply-To: <1375305626-26972-1-git-send-email-rjones@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] block/iscsi.c: Fix printf format error. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, afaerber@suse.de Am 31.07.2013 23:20, schrieb Richard W.M. Jones: > From: "Richard W.M. Jones" > > The error on armv7hl was: > > block/iscsi.c: In function =E2=80=98is_request_lun_aligned=E2=80=99: > block/iscsi.c:251:26: error: format =E2=80=98%ld=E2=80=99 expects argum= ent of type =E2=80=98long int=E2=80=99, but argument 3 has type =E2=80=98= int64_t=E2=80=99 [-Werror=3Dformat=3D] > iscsilun->block_size, sector_num, nb_sectors)= ; > ^ > > This also splits the long line to comply with qemu coding guidelines. > > Signed-off-by: Richard W.M. Jones > --- > block/iscsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 5f28c6a..e7c1c2b 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -247,7 +247,9 @@ static bool is_request_lun_aligned(int64_t sector_n= um, int nb_sectors, > { > if ((sector_num * BDRV_SECTOR_SIZE) % iscsilun->block_size || > (nb_sectors * BDRV_SECTOR_SIZE) % iscsilun->block_size) { > - error_report("iSCSI misaligned request: iscsilun->block_si= ze %u, sector_num %ld, nb_sectors %d", > + error_report("iSCSI misaligned request: " > + "iscsilun->block_size %u, sector_num %" PRIi6= 4 > + ", nb_sectors %d", > iscsilun->block_size, sector_num, nb_sectors)= ; > return 0; > } Reviewed-by: Stefan Weil