From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56640)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4t8P-0007Ir-BE
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 09:41:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4t8H-0004dZ-TS
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 09:41:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:58133 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V4sy1-0000tC-1k
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 09:30:57 -0400
Message-ID: <51FA630D.7050504@suse.de>
Date: Thu, 01 Aug 2013 15:30:53 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372055699-13501-1-git-send-email-akong@redhat.com>
	<20130626031532.GA2341@amosk.info>
	<87vc51i3ra.fsf@blackfin.pond.sub.org>
	<20130701025528.GB1946@amosk.info>
In-Reply-To: <20130701025528.GB1946@amosk.info>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in
 NIC_RX_FILTER_CHANGED event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: mst@redhat.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Am 01.07.2013 04:55, schrieb Amos Kong:
> On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote:
>> Amos Kong <akong@redhat.com> writes:
>>
>>> On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote:
>>>> netclient 'name' entry in event is useful for management to know
>>>> which device is changed. n->netclient_name is not always set.
>>>> This patch changes to use nc->name. If we don't assign 'id',
>>>> qemu will set a generated name to nc->name.
>>>
>>>
>>> IRC: <mst> akong, what do other events include? name or id?
>>>
>>> I just checked QMP/qmp-event.txt, they all use 'device name'.
>>> (eg: BLOCK_IO_ERROR, DEVICE_DELETED, DEVICE_TRAY_MOVED, BLOCK_JOB_*)
>>>
>>> If we assign 'id' for -device, device name will be set to id.
>>> Otherwise, a generated device name will set to some device.
>>
>> DEVICE_DELETED uses "device" (the qdev ID) and "path" (the QOM path).
>>
>> For reasons I don't understand, it sets "path" only when the device ha=
s
>> no qdev ID.  That should be cleaned up.
>=20
> The path are alwasy set.
>=20
> example:
> (have id)
>   "path": "/machine/peripheral-anon/vnet0/virtio-backend"

You hopefully meant "/machine/peripheral/vnet0/virtio-backend"?
Otherwise we have a bug somewhere.

Andreas

>=20
> (no id)
>   "path": "/machine/peripheral-anon/device[0]/virtio-backend"
>=20
> It's enough to just use path to distinguish the changed device.
> So we ignore this patch.
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg