From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1V59jv-0005No-6r
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 03:25:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1V59jl-00062e-M3
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 03:25:31 -0400
Received: from e23smtp07.au.ibm.com ([202.81.31.140]:50107)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1V59jl-0005gn-34
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 03:25:21 -0400
Received: from /spool/local
	by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Fri, 2 Aug 2013 17:12:05 +1000
Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120])
	by d23dlp01.au.ibm.com (Postfix) with ESMTP id 0B1232CE804C
	for <qemu-devel@nongnu.org>; Fri,  2 Aug 2013 17:24:53 +1000 (EST)
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r7279IoK65994794
	for <qemu-devel@nongnu.org>; Fri, 2 Aug 2013 17:09:18 +1000
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r727OqkW027534
	for <qemu-devel@nongnu.org>; Fri, 2 Aug 2013 17:24:52 +1000
Message-ID: <51FB5E72.8060400@linux.vnet.ibm.com>
Date: Fri, 02 Aug 2013 15:23:30 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1375265640-27307-1-git-send-email-famz@redhat.com>
	<1375265640-27307-2-git-send-email-famz@redhat.com>
In-Reply-To: <1375265640-27307-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate
 BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

> we need bdrv_new() to properly initialize BDS, don't allocate memory
> manually.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block/vvfat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index cd3b8ed..a827d91 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s)
>       unlink(s->qcow_filename);
>   #endif
> 
> -    s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1);
> +    s->bs->backing_hd = bdrv_new("");
>       s->bs->backing_hd->drv = &vvfat_write_target;
>       s->bs->backing_hd->opaque = g_malloc(sizeof(void*));
>       *(void**)s->bs->backing_hd->opaque = s;
> 


-- 
Best Regards

Wenchao Xia