From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5AW7-0007Vb-4s for qemu-devel@nongnu.org; Fri, 02 Aug 2013 04:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5AVx-0006Mk-Dy for qemu-devel@nongnu.org; Fri, 02 Aug 2013 04:15:19 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:45653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5AVw-0006Ks-NR for qemu-devel@nongnu.org; Fri, 02 Aug 2013 04:15:09 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 13:36:13 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 896131258055 for ; Fri, 2 Aug 2013 13:44:32 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r728G7sr39256206 for ; Fri, 2 Aug 2013 13:46:07 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r728ExkA024469 for ; Fri, 2 Aug 2013 18:14:59 +1000 Message-ID: <51FB6A43.1050108@linux.vnet.ibm.com> Date: Fri, 02 Aug 2013 16:13:55 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1375265640-27307-1-git-send-email-famz@redhat.com> <1375265640-27307-6-git-send-email-famz@redhat.com> In-Reply-To: <1375265640-27307-6-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/7] migration: omit drive ref as we have bdrv_ref now List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com There should be a section of code in device hot unplug, checking DriverInfo's ref, fail or do nothing when ref != 1. But I haven't found that code, so not sure whether this patch will change the behavior in device hot unplug. > block-migration.c does not actually use DriveInfo anywhere. Hence it's > safe to drive ref code, we really only care about referencing BDS. > > Signed-off-by: Fam Zheng > --- > block-migration.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block-migration.c b/block-migration.c > index f803f20..daf9ec1 100644 > --- a/block-migration.c > +++ b/block-migration.c > @@ -336,8 +336,8 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs) > bmds->completed_sectors = 0; > bmds->shared_base = block_mig_state.shared_base; > alloc_aio_bitmap(bmds); > - drive_get_ref(drive_get_by_blockdev(bs)); > bdrv_set_in_use(bs, 1); > + bdrv_ref(bs); > > block_mig_state.total_sector_sum += sectors; > > @@ -575,7 +575,7 @@ static void blk_mig_cleanup(void) > while ((bmds = QSIMPLEQ_FIRST(&block_mig_state.bmds_list)) != NULL) { > QSIMPLEQ_REMOVE_HEAD(&block_mig_state.bmds_list, entry); > bdrv_set_in_use(bmds->bs, 0); > - drive_put_ref(drive_get_by_blockdev(bmds->bs)); > + bdrv_unref(bmds->bs); > g_free(bmds->aio_bitmap); > g_free(bmds); > } > -- Best Regards Wenchao Xia