From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5FUU-0007Yr-5j for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:34:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5FUN-0007LU-VJ for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:33:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47427 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5FUN-0007L4-MP for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:33:51 -0400 Message-ID: <51FBB53C.8040708@suse.de> Date: Fri, 02 Aug 2013 15:33:48 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375407789-5885-1-git-send-email-tiejun.chen@windriver.com> In-Reply-To: <1375407789-5885-1-git-send-email-tiejun.chen@windriver.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [v2][PATCH 1/1] cpus: use cpu_is_stopped efficiently List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tiejun Chen Cc: mtosatti@redhat.com, qemu-devel@nongnu.org Am 02.08.2013 03:43, schrieb Tiejun Chen: > It makes more sense and simple later. >=20 > Signed-off-by: Tiejun Chen > --- > v1 -> v2: >=20 > To optimize performance slightly, we can reorder the two conditions to > avoid the non-inline function call if cpu->stopped. Patch doesn't apply to qemu.git: next_cpu and cpu_thread_is_idle() use CPUState since a few weeks and do_vm_stop() changed from void to int. Please remember to rebase before sending patches. Thanks, applied to qom-cpu-next (with modified commit message): https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg