From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Isaku Yamahata <yamahata@private.email.ne.jp>
Cc: owasserm@redhat.com, quintela@redhat.com, mrhines@us.ibm.com,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY
Date: Fri, 02 Aug 2013 09:40:14 -0400 [thread overview]
Message-ID: <51FBB6BE.8020000@linux.vnet.ibm.com> (raw)
In-Reply-To: <3d7c209918e388c331add55b2552379852fab96a.1375415452.git.yamahata@private.email.ne.jp>
On 08/01/2013 11:56 PM, Isaku Yamahata wrote:
> Cc: Michael R. Hines <mrhines@us.ibm.com>
> Signed-off-by: Isaku Yamahata <yamahata@private.email.ne.jp>
> ---
> migration-rdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index 67069d2..871f9cd 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -2221,7 +2221,7 @@ static int qemu_rdma_connect(RDMAContext *rdma, Error **errp)
>
> rdma_ack_cm_event(cm_event);
>
> - ret = qemu_rdma_post_recv_control(rdma, 0);
> + ret = qemu_rdma_post_recv_control(rdma, RDMA_WRID_READY);
> if (ret) {
> ERROR(errp, "posting second control recv!\n");
> goto err_rdma_source_connect;
> @@ -2726,7 +2726,7 @@ static int qemu_rdma_accept(RDMAContext *rdma)
>
> rdma_ack_cm_event(cm_event);
>
> - ret = qemu_rdma_post_recv_control(rdma, 0);
> + ret = qemu_rdma_post_recv_control(rdma, RDMA_WRID_READY);
> if (ret) {
> fprintf(stderr, "rdma migration: error posting second control recv!\n");
> goto err_rdma_dest_wait;
Good catch too.
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
next prev parent reply other threads:[~2013-08-02 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 3:56 [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups Isaku Yamahata
2013-08-02 3:56 ` [Qemu-devel] [PATCH 1/3] rdma: don't use negative index to array Isaku Yamahata
2013-08-02 13:28 ` Michael R. Hines
2013-08-02 3:56 ` [Qemu-devel] [PATCH 2/3] rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX Isaku Yamahata
2013-08-02 13:40 ` Michael R. Hines
2013-08-02 3:56 ` [Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY Isaku Yamahata
2013-08-02 13:40 ` Michael R. Hines [this message]
2013-08-02 13:40 ` [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups Michael R. Hines
2013-08-04 1:24 ` Isaku Yamahata
2013-08-04 2:55 ` Michael R. Hines
2013-08-14 16:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBB6BE.8020000@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yamahata@private.email.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).