From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5Fam-0002w9-7a for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:40:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5Fad-0001ZF-R7 for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:40:28 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:52034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5Fad-0001Z0-KV for qemu-devel@nongnu.org; Fri, 02 Aug 2013 09:40:19 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 14:40:18 +0100 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 7EF87C90041 for ; Fri, 2 Aug 2013 09:40:15 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r72DeHGK134612 for ; Fri, 2 Aug 2013 09:40:17 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r72DeGih027233 for ; Fri, 2 Aug 2013 09:40:16 -0400 Message-ID: <51FBB6BE.8020000@linux.vnet.ibm.com> Date: Fri, 02 Aug 2013 09:40:14 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <3d7c209918e388c331add55b2552379852fab96a.1375415452.git.yamahata@private.email.ne.jp> In-Reply-To: <3d7c209918e388c331add55b2552379852fab96a.1375415452.git.yamahata@private.email.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] rdma: use RDMA_WRID_READY List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: owasserm@redhat.com, quintela@redhat.com, mrhines@us.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com On 08/01/2013 11:56 PM, Isaku Yamahata wrote: > Cc: Michael R. Hines > Signed-off-by: Isaku Yamahata > --- > migration-rdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration-rdma.c b/migration-rdma.c > index 67069d2..871f9cd 100644 > --- a/migration-rdma.c > +++ b/migration-rdma.c > @@ -2221,7 +2221,7 @@ static int qemu_rdma_connect(RDMAContext *rdma, Error **errp) > > rdma_ack_cm_event(cm_event); > > - ret = qemu_rdma_post_recv_control(rdma, 0); > + ret = qemu_rdma_post_recv_control(rdma, RDMA_WRID_READY); > if (ret) { > ERROR(errp, "posting second control recv!\n"); > goto err_rdma_source_connect; > @@ -2726,7 +2726,7 @@ static int qemu_rdma_accept(RDMAContext *rdma) > > rdma_ack_cm_event(cm_event); > > - ret = qemu_rdma_post_recv_control(rdma, 0); > + ret = qemu_rdma_post_recv_control(rdma, RDMA_WRID_READY); > if (ret) { > fprintf(stderr, "rdma migration: error posting second control recv!\n"); > goto err_rdma_dest_wait; Good catch too. Reviewed-by: Michael R. Hines