From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/4] qemu-ga: build it even if !system
Date: Fri, 02 Aug 2013 16:57:36 +0200 [thread overview]
Message-ID: <51FBC8E0.7070807@suse.de> (raw)
In-Reply-To: <1375453248-7178-2-git-send-email-mjt@msgid.tls.msk.ru>
Am 02.08.2013 16:20, schrieb Michael Tokarev:
> Move qemu-ga build check out of if softmmu.. into its own section.
> We want to build qemu-ga for _guest_ even if system build isn't
> done. It is controlled separately using --enable-guest-agent.
> Additionally, give error message if guest agent is requested but
> not supported.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> configure | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index f0761ea..293f167 100755
> --- a/configure
> +++ b/configure
> @@ -231,7 +231,7 @@ libusb=""
> usb_redir=""
> glx=""
> zlib="yes"
> -guest_agent="yes"
> +guest_agent=""
> want_tools="yes"
> libiscsi=""
> coroutine=""
> @@ -3444,10 +3444,15 @@ if test "$softmmu" = yes ; then
> virtfs=no
> fi
> fi
> +fi
> +if [ "$guest_agent" != "no" ]; then
> if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
> - if [ "$guest_agent" = "yes" ]; then
> tools="qemu-ga\$(EXESUF) $tools"
> - fi
> + guest_agent=yes
> + elif [ "$guest_agent" != yes ]; then
> + guest_agent=no
> + else
> + error_exit "Guest agent is not supported on this platform"
> fi
> fi
You are mixing 2- and 4-char indentation here...
Andreas
>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-02 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 14:20 [Qemu-devel] [PULL 0/4] trivial patches for 2013-08-02 Michael Tokarev
2013-08-02 14:20 ` [Qemu-devel] [PULL 1/4] qemu-ga: build it even if !system Michael Tokarev
2013-08-02 14:57 ` Andreas Färber [this message]
2013-08-02 14:20 ` [Qemu-devel] [PULL 2/4] block/iscsi.c: Fix printf format error Michael Tokarev
2013-08-02 14:20 ` [Qemu-devel] [PULL 3/4] memory.c: drop kvm.h dependency Michael Tokarev
2013-08-02 14:20 ` [Qemu-devel] [PULL 4/4] vmdk: fix comment for vmdk_co_write_zeroes Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBC8E0.7070807@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).