From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5I0H-0000Td-HW for qemu-devel@nongnu.org; Fri, 02 Aug 2013 12:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5I0B-0006GY-4b for qemu-devel@nongnu.org; Fri, 02 Aug 2013 12:14:57 -0400 Message-ID: <51FBDAF6.10302@suse.de> Date: Fri, 02 Aug 2013 18:14:46 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375412374-24701-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1375412374-24701-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER7+ CPU model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Paul Mackerras , Anthony Liguori , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf Am 02.08.2013 04:59, schrieb Alexey Kardashevskiy: > This patch adds CPU PVR definition for POWER7+. >=20 > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/cpu-models.c | 2 ++ > target-ppc/cpu-models.h | 1 + > 2 files changed, 3 insertions(+) >=20 > diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c > index 9578ed8..c97c183 100644 > --- a/target-ppc/cpu-models.c > +++ b/target-ppc/cpu-models.c > @@ -1143,6 +1143,8 @@ > "POWER7 v2.1") > POWERPC_DEF("POWER7_v2.3", CPU_POWERPC_POWER7_v23, P= OWER7, > "POWER7 v2.3") > + POWERPC_DEF("POWER7P", CPU_POWERPC_POWER7P, P= OWER7, > + "POWER7P") Subject says POWER7+ rather than POWER7P. Since this is a string there's nothing wrong with +. How should it show up in SLOF? See also below. > POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10, P= OWER8, > "POWER8 v1.0") > POWERPC_DEF("970", CPU_POWERPC_970, 9= 70, > diff --git a/target-ppc/cpu-models.h b/target-ppc/cpu-models.h > index 01e488f..c3c78d1 100644 > --- a/target-ppc/cpu-models.h > +++ b/target-ppc/cpu-models.h > @@ -556,6 +556,7 @@ enum { > CPU_POWERPC_POWER7_v20 =3D 0x003F0200, > CPU_POWERPC_POWER7_v21 =3D 0x003F0201, > CPU_POWERPC_POWER7_v23 =3D 0x003F0203, > + CPU_POWERPC_POWER7P =3D 0x004A0201, Shouldn't this be ..._POWER7P_v21 to align with the surrounding models? Ditto for the model name then, POWER7+ being an alias to the latest version only. The first field becomes part of the type name, so we should properly name it from the start. Andreas > CPU_POWERPC_POWER8_v10 =3D 0x004B0100, > CPU_POWERPC_970 =3D 0x00390202, > CPU_POWERPC_970FX_v10 =3D 0x00391100, --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg