From: Richard Henderson <rth@twiddle.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-1.6] pc: disable pci-info for 1.6
Date: Fri, 02 Aug 2013 06:19:31 -1000 [thread overview]
Message-ID: <51FBDC13.4040303@twiddle.net> (raw)
In-Reply-To: <20130801124204.GA25947@redhat.com>
On 08/01/2013 02:42 AM, Michael S. Tsirkin wrote:
> -static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
> +static void pc_init_pci_1_6(QEMUMachineInitArgs *args)
> {
> has_pci_info = false;
> pc_init_pci(args);
> }
>
> +static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
> +{
> + pc_init_pci(args);
> +}
Surely the numbers aren't right here. Aren't you now enabling
pci_info for 1.5, when it was disabled previously?
r~
prev parent reply other threads:[~2013-08-02 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 12:42 [Qemu-devel] [PATCH for-1.6] pc: disable pci-info for 1.6 Michael S. Tsirkin
2013-08-02 16:19 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBDC13.4040303@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).