From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V5IKF-0006ty-7F
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 12:35:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V5IK6-0004xp-Rv
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 12:35:35 -0400
Received: from mail-ve0-x234.google.com ([2607:f8b0:400c:c01::234]:38356)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1V5I4p-0007tH-4p
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 12:19:39 -0400
Received: by mail-ve0-f180.google.com with SMTP id pb11so883234veb.39
	for <qemu-devel@nongnu.org>; Fri, 02 Aug 2013 09:19:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51FBDC13.4040303@twiddle.net>
Date: Fri, 02 Aug 2013 06:19:31 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <20130801124204.GA25947@redhat.com>
In-Reply-To: <20130801124204.GA25947@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.6] pc: disable pci-info for 1.6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 08/01/2013 02:42 AM, Michael S. Tsirkin wrote:
> -static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
> +static void pc_init_pci_1_6(QEMUMachineInitArgs *args)
>  {
>      has_pci_info = false;
>      pc_init_pci(args);
>  }
>  
> +static void pc_init_pci_1_5(QEMUMachineInitArgs *args)
> +{
> +    pc_init_pci(args);
> +}

Surely the numbers aren't right here.  Aren't you now enabling
pci_info for 1.5, when it was disabled previously?


r~