From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5L7o-0007PS-BK for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:35:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5L7f-0007B3-8y for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:34:56 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:58003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5L7f-000785-1l for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:34:47 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 13:34:43 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 265D93E4003E for ; Fri, 2 Aug 2013 13:34:17 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r72JYd0s044282 for ; Fri, 2 Aug 2013 13:34:39 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r72JYcc4010152 for ; Fri, 2 Aug 2013 13:34:38 -0600 Message-ID: <51FC09CC.7050801@linux.vnet.ibm.com> Date: Fri, 02 Aug 2013 15:34:36 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1371397053-4503-1-git-send-email-lilei@linux.vnet.ibm.com> <1371397053-4503-4-git-send-email-lilei@linux.vnet.ibm.com> <878v2ahwj1.fsf@codemonkey.ws> In-Reply-To: <878v2ahwj1.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/7] arch_init: add ram_madvise_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lagarcia@br.ibm.com, quintela@redhat.com, Lei Li , qemu-devel@nongnu.org On 06/16/2013 12:04 PM, Anthony Liguori wrote: > Lei Li writes: > >> Signed-off-by: Lei Li >> --- >> arch_init.c | 13 +++++++++++++ >> include/migration/migration.h | 3 +++ >> 2 files changed, 16 insertions(+), 0 deletions(-) >> >> diff --git a/arch_init.c b/arch_init.c >> index 872020e..fc66bd2 100644 >> --- a/arch_init.c >> +++ b/arch_init.c >> @@ -524,6 +524,19 @@ uint64_t ram_bytes_total(void) >> return total; >> } >> >> +void ram_madvise_free(ram_addr_t size) >> +{ >> + void *ram; >> + RAMBlock *block = NULL; >> + >> + ram = memory_region_get_ram_ptr(block->mr); >> + >> + /* XXX. Here just simplely madvise(.., MADV_DONTNEED) the whole ram >> + * pages, need more work to keep MADV_DONTNEED ram pages that >> + * already sent. */ >> + qemu_madvise(ram, size, MADV_DONTNEED); >> +} >> + > I don't think this is right at all. There's no guarantee we have a > single linear mapping of all ram. > > I think you need something a bit more clever than this. > >> static void migration_end(void) >> { >> if (migration_bitmap) { >> diff --git a/include/migration/migration.h b/include/migration/migration.h >> index 8866c3c..9cc5285 100644 >> --- a/include/migration/migration.h >> +++ b/include/migration/migration.h >> @@ -21,6 +21,7 @@ >> #include "qapi/error.h" >> #include "migration/vmstate.h" >> #include "qapi-types.h" >> +#include "exec/memory.h" >> >> enum { >> MIG_STATE_ERROR, >> @@ -100,6 +101,8 @@ uint64_t ram_bytes_remaining(void); >> uint64_t ram_bytes_transferred(void); >> uint64_t ram_bytes_total(void); >> >> +void ram_madvise_free(ram_addr_t size); >> + > If you introduce new interfaces, please include documentation in the > header. > > Regards, > > Anthony Liguori > >> extern SaveVMHandlers savevm_ram_handlers; >> >> uint64_t dup_mig_bytes_transferred(void); >> -- >> 1.7.7.6 > We have a new function in master...... ram_handle_compressed() (was exported for RDMA). Perhaps this could be used..... - Michael