From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5LFC-0005f8-PA for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:42:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5LF3-0003bO-OO for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:42:34 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:45503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5LF3-0003b7-J1 for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:42:25 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 13:42:24 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id B5BEA1FF001C for ; Fri, 2 Aug 2013 13:36:58 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r72JgJ2s181920 for ; Fri, 2 Aug 2013 13:42:20 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r72JgI9D031935 for ; Fri, 2 Aug 2013 13:42:19 -0600 Message-ID: <51FC0B97.5060409@linux.vnet.ibm.com> Date: Fri, 02 Aug 2013 15:42:15 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1374783499-2550-1-git-send-email-lilei@linux.vnet.ibm.com> <1374783499-2550-6-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1374783499-2550-6-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] arch_init: introduce ram_save_local() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, lagarcia@br.ibm.com, pbonzini@redhat.com, rcj@linux.vnet.ibm.com On 07/25/2013 04:18 PM, Lei Li wrote: > Signed-off-by: Lei Li > --- > arch_init.c | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index a418071..7eeb52f 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -757,6 +757,38 @@ static int ram_page_save(QEMUFile *f) > return bytes_sent; > } > > +static int ram_save_local(QEMUFile *f, void *opaque) > +{ > + uint64_t bytes_sent = 0; > + uint64_t total_ram_bytes = ram_bytes_total(); > + > + qemu_mutex_lock_ramlist(); > + > + while (total_ram_bytes) { > + void *ram; > + MemoryRegion *mr; > + > + bytes_sent = ram_page_save(f); > + /* No more ram pages. */ > + if (bytes_sent == 0) { > + return bytes_sent; > + } > + > + mr = last_block_local->mr; > + ram = memory_region_get_ram_ptr(mr) + last_offset_local; > + > + /* DONTNEED the ram page that has already copied. */ > + qemu_madvise(ram, bytes_sent, QEMU_MADV_DONTNEED); > + total_ram_bytes -= bytes_sent; > + } > + > + qemu_mutex_unlock_ramlist(); > + > + qemu_put_be64(f, RAM_SAVE_FLAG_EOS); > + > + return bytes_sent; > +} > + > static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host) > { > int ret, rc = 0; You need to create a new private structure "QEMUFileLocal". Then override f->save_page and point this to your own function. See migration-rdma.c for an example. - Michael