From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5LJa-0002vH-4f for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5LJR-00066d-1v for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:47:06 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:45884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5LJQ-00066T-UK for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:46:56 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Aug 2013 20:46:56 +0100 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id E42B4C90044 for ; Fri, 2 Aug 2013 15:46:51 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r72JkqNY105072 for ; Fri, 2 Aug 2013 15:46:52 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r72JnX1N019943 for ; Fri, 2 Aug 2013 13:49:33 -0600 Message-ID: <51FC0CA9.2000508@linux.vnet.ibm.com> Date: Fri, 02 Aug 2013 15:46:49 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1374783499-2550-1-git-send-email-lilei@linux.vnet.ibm.com> <1374783499-2550-12-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1374783499-2550-12-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, lagarcia@br.ibm.com, pbonzini@redhat.com, rcj@linux.vnet.ibm.com On 07/25/2013 04:18 PM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-options.hx | 9 +++++++++ > vl.c | 14 ++++++++++++++ > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 8355f9b..a975e83 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2912,6 +2912,15 @@ STEXI > Prepare for incoming migration, listen on @var{port}. > ETEXI > > +DEF("incoming-local", HAS_ARG, QEMU_OPTION_incoming_local, \ > + "-incoming-local p prepare for localhost incoming migration, listen on domain unix socket p\n", > + QEMU_ARCH_ALL) > +STEXI > +@item -incoming-local @var{port} > +@findex -incoming-local > +Prepare for localhost incoming migration, listen on @var{port} > +ETEXI > + > DEF("nodefaults", 0, QEMU_OPTION_nodefaults, \ > "-nodefaults don't create default devices\n", QEMU_ARCH_ALL) > STEXI > diff --git a/vl.c b/vl.c > index 767e020..b820db5 100644 > --- a/vl.c > +++ b/vl.c > @@ -2854,6 +2854,7 @@ int main(int argc, char **argv, char **envp) > const char *vga_model = "none"; > const char *pid_file = NULL; > const char *incoming = NULL; > + const char *incoming_local = NULL; > #ifdef CONFIG_VNC > int show_vnc_port = 0; > #endif > @@ -3691,6 +3692,10 @@ int main(int argc, char **argv, char **envp) > incoming = optarg; > runstate_set(RUN_STATE_INMIGRATE); > break; > + case QEMU_OPTION_incoming_local: > + incoming_local = optarg; > + runstate_set(RUN_STATE_INMIGRATE); > + break; > case QEMU_OPTION_nodefaults: > default_serial = 0; > default_parallel = 0; > @@ -4377,6 +4382,15 @@ int main(int argc, char **argv, char **envp) > error_free(local_err); > exit(1); > } > + } else if (incoming_local) { > + Error *local_err = NULL; > + qemu_start_local_incoming_migration(incoming_local, &local_err); > + if (local_err) { > + fprintf(stderr, "-incoming_local %s: %s\n", incoming_local, > + error_get_pretty(local_err)); > + error_free(local_err); > + exit(1); > + } > } else if (autostart) { > vm_start(); > } Why can't we do: -incoming "local:" instead of adding a new flag? Would be much more compatible with libvirt tools if you just add a new URI prefix..... - Michael