From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5NrB-0002Hd-Aq for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:30:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5Nr3-0004u3-7s for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:29:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5Nr2-0004tt-VK for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:29:49 -0400 Message-ID: <51FC32D5.4070609@redhat.com> Date: Fri, 02 Aug 2013 16:29:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1375434137-4452-1-git-send-email-gesaint@linux.vnet.ibm.com> <1375434137-4452-5-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1375434137-4452-5-git-send-email-gesaint@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fJ20H3Q8itEfPTviTI2LC0S1bVcr65JEg" Subject: Re: [Qemu-devel] [PATCH V5 4/6] block: Check infinite loop in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fJ20H3Q8itEfPTviTI2LC0S1bVcr65JEg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/02/2013 03:02 AM, Xu Wang wrote: > From: Xu Wang >=20 > Backing file loop should be checked before qemu-img create command > execution. If loop was found, qemu-img create should be stopped and s/was/is/ - commit messages should generally be in present tense (what the code is doing now that the patch is applied) not in past tense. > an error was printed. s/was // >=20 > Signed-off-by: Xu Wang > --- > block.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > =20 > backing_file =3D get_option_parameter(param, BLOCK_OPT_BACKING_FIL= E); > + backing_fmt =3D get_option_parameter(param, BLOCK_OPT_BACKING_FMT)= ; > if (backing_file && backing_file->value.s) { > - if (!strcmp(filename, backing_file->value.s)) { > - error_setg(errp, "Error: Trying to create an image with th= e " > - "same filename as the backing file"); > + if (bdrv_backing_file_loop_check(filename, fmt, > + backing_file->value.s, > + backing_fmt->value.s)) { > + error_report("bdrv_img_create: loop exists, image create f= ailed."); No '.' in error messages. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fJ20H3Q8itEfPTviTI2LC0S1bVcr65JEg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR/DLVAAoJEKeha0olJ0NqTh0H/34loFWXZ9iDO0+q5VXqw3/B 3caLkbLcVeNUseKz9V7DcEVL7kDCrvtcylABqWX3PunvebtOPB5alQgVs75R7uFd I/u0T1sQTOzh+2JUt140qt0kvzHfEuPxjb+Rz20yBKLWqnzhQMFZR5I9xVn/eOth MbptQcwQedDVUw61F7t1Nz652mxg9xw8KvAP9kxW220qmkA62Lw77VxghgvrA5Zt +YebIbA2UlJcKLf9dNyvI1zDchKIqBeu2e5Reo+sOKmj7/NKBYNY2U6LdNcQ+/nD rIhfZ/omz6bkzIsVe026wKeUbjJH1QWg7lD26Yy3WkaTTdto9YoD9Zm2o6Rl75E= =mLNA -----END PGP SIGNATURE----- --fJ20H3Q8itEfPTviTI2LC0S1bVcr65JEg--