From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5Nsl-0003Or-74 for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:31:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5Nsg-0005Pm-Bo for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:31:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5Nsg-0005Pg-2j for qemu-devel@nongnu.org; Fri, 02 Aug 2013 18:31:30 -0400 Message-ID: <51FC333D.3050108@redhat.com> Date: Fri, 02 Aug 2013 16:31:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1375434137-4452-1-git-send-email-gesaint@linux.vnet.ibm.com> <1375434137-4452-6-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1375434137-4452-6-git-send-email-gesaint@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5cRNlnEti2UPILibsfNa0wOmNUis6OXww" Subject: Re: [Qemu-devel] [PATCH V5 5/6] block: Add backing file loop check in change_backing_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5cRNlnEti2UPILibsfNa0wOmNUis6OXww Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/02/2013 03:02 AM, Xu Wang wrote: > From: Xu Wang >=20 > Backing file loop should be checked before calling change_backing_ > file(). If loop appeared, this calling should be stopped and an Breaking a function name across a line break is awkward. > error was printed. s/was // >=20 > Signed-off-by: Xu Wang > --- > block.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > =20 > + /* Check if loop exists in backing files chain after changed */ s/changed/change/ But isn't that a bit late? Don't you want to check that a backing loop will not be created, prior to making the change? > + if (bdrv_backing_file_loop_check(bs->filename, > + bs->drv ? bs->drv->format_name : = NULL, > + backing_file, backing_fmt)) { > + return -EIO; > + } > + > if (drv->bdrv_change_backing_file !=3D NULL) { > ret =3D drv->bdrv_change_backing_file(bs, backing_file, backin= g_fmt); > } else { >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5cRNlnEti2UPILibsfNa0wOmNUis6OXww Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR/DM9AAoJEKeha0olJ0NqvJMH/A53pnflKeuQqvhJQ6QKlok6 nrEw9Bit0XRwBuATJdK/Kkcf9uW0jxEIN3gXqkNOhrxMDXzUkVCJtJaacETn1VlT 24cI8NXWkeTgbCgkNX+uGN+2IGx3OEYlcH0wL+J3n2N/0nkxa9OA04muFvA3HxWL URuRSVUTSszX0PsbNf+G/Jnl9wJX+meXty6Rr082HtYY9k5c0Y9C5pztvSut0gPl gZxx0827R4xh5dogu8+876gyeNF6qN1XTxyZ08cIF254ZoaO7K9Sl4Hf2FR8Tfv3 H1WbtaTjfi5kCY1s8+/7ieKJndLVdzEJ7mXsu4vd1lmAgjVtoGADYdJtT3d2cMo= =px41 -----END PGP SIGNATURE----- --5cRNlnEti2UPILibsfNa0wOmNUis6OXww--