From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6I6S-0001Cw-0l for qemu-devel@nongnu.org; Mon, 05 Aug 2013 06:33:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6I6J-0008C4-3S for qemu-devel@nongnu.org; Mon, 05 Aug 2013 06:33:27 -0400 Message-ID: <51FF7F6A.50902@redhat.com> Date: Mon, 05 Aug 2013 12:33:14 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1375692609-3730-1-git-send-email-kraxel@redhat.com> <51FF7440.1040404@suse.de> In-Reply-To: <51FF7440.1040404@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pci: fix i82801b11 bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-stable , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 08/05/13 11:45, Andreas F=E4rber wrote: > Am 05.08.2013 10:50, schrieb Gerd Hoffmann: >> Signed-off-by: Gerd Hoffmann >> --- >> hw/pci-bridge/i82801b11.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c >> index 8a5e426..14cd7fd 100644 >> --- a/hw/pci-bridge/i82801b11.c >> +++ b/hw/pci-bridge/i82801b11.c >> @@ -90,6 +90,7 @@ static void i82801b11_bridge_class_init(ObjectClass = *klass, void *data) >> k->device_id =3D PCI_DEVICE_ID_INTEL_82801BA_11; >> k->revision =3D ICH9_D2P_A2_REVISION; >> k->init =3D i82801b11_bridge_initfn; >> + k->config_write =3D pci_bridge_write_config; >> set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); >> } >> =20 >=20 > We have an abstract TYPE_PCI_BRIDGE now, suggest to set it in its > class_init instead if that's a generic bridge function. Well, depends on the bridge device. When they have stuff beside core pci bridge functionality (such as shpc hotplug support like the 'pci-bridge' device) they need their private function. But those can still override config_write in the device init I guess. /me leaves that to mst to decide. Beside that it should most likely go into a separate cleanup patch as there are other devices which hook pci_bridge_write_config the same way. > Probably should be for-1.6? Yes. cheers, Gerd