From: "Andreas Färber" <afaerber@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling
Date: Mon, 05 Aug 2013 14:06:07 +0200 [thread overview]
Message-ID: <51FF952F.3060307@suse.de> (raw)
In-Reply-To: <1375464135-29543-1-git-send-email-afaerber@suse.de>
Am 02.08.2013 19:22, schrieb Andreas Färber:
> Error **errp argument is not for emitting warnings, it means an error
> has occurred and the caller should not make any assumptions about the
> state of other return values (unless otherwise documented).
>
> Therefore cpu_x86_create() must unref the new X86CPU itself, and
> pc_new_cpu() must check for an Error rather than NULL return value.
>
> While at it, clean up a superfluous NULL check.
>
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: qemu-stable@nongnu.org
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Ping! Jan, does this address your concerns / use cases?
-rc2 is on Wednesday.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-08-05 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 11:00 [Qemu-devel] Error handling in cpu_x86_create Jan Kiszka
2013-07-30 12:21 ` Igor Mammedov
2013-08-02 15:39 ` Jan Kiszka
2013-08-02 17:22 ` [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling Andreas Färber
2013-08-05 12:06 ` Andreas Färber [this message]
2013-08-05 12:09 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF952F.3060307@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).